[patch] move ExtWeakSymbols to AsmPrinter

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch] move ExtWeakSymbols to AsmPrinter

Rafael Espíndola
The attached patch moves the ExtWeakSymbols to the AsmPrinter class
and the code that emits the ".weak" directives to
AsmPrinter::doFinalization.

This is just code factoring. No functionality changes.

Best Regards,
Rafael

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

llvm.patch (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [patch] move ExtWeakSymbols to AsmPrinter

Chris Lattner
On Sat, 9 Dec 2006, [UTF-8] Rafael Esp?ndola wrote:
> The attached patch moves the ExtWeakSymbols to the AsmPrinter class
> and the code that emits the ".weak" directives to
> AsmPrinter::doFinalization.
>
> This is just code factoring. No functionality changes.

Looks good, one request though: if practical, it would be nice to switch
this to be set<GlobalValue*> instead of set<std::string>.

-Chris

--
http://nondot.org/sabre/
http://llvm.org/
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [patch] move ExtWeakSymbols to AsmPrinter

Rafael Espíndola
> Looks good, one request though: if practical, it would be nice to switch
> this to be set<GlobalValue*> instead of set<std::string>.

Attached

> -Chris

Rafael

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

llvm.patch (10K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [patch] move ExtWeakSymbols to AsmPrinter

Rafael Espíndola
On 12/11/06, Rafael Espíndola <[hidden email]> wrote:
> > Looks good, one request though: if practical, it would be nice to switch
> > this to be set<GlobalValue*> instead of set<std::string>.
>
> Attached

OK to commit?

Rafael

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [patch] move ExtWeakSymbols to AsmPrinter

Chris Lattner
In reply to this post by Rafael Espíndola
On Mon, 11 Dec 2006, [UTF-8] Rafael Esp?ndola wrote:
>>  Looks good, one request though: if practical, it would be nice to switch
>>  this to be set<GlobalValue*> instead of set<std::string>.
>
> Attached

Sorry for the delay, looks great, please apply!

-Chris

--
http://nondot.org/sabre/
http://llvm.org/
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev