[patch] fix gcc build failure on arm

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch] fix gcc build failure on arm

Rafael Espíndola
The attached patch implements iasm_memory_clobber so that cc1 links
correctly on arm targets.

Best Regards,
Rafael

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

gcc.patch (780 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [patch] fix gcc build failure on arm

Devang Patel

On Oct 3, 2006, at 6:35 AM, Rafael Espíndola wrote:

> The attached patch implements iasm_memory_clobber so that cc1 links
> correctly on arm targets.
>
> Best Regards,
> Rafael
> <gcc.patch>


Thanks. Applied.

iasm_memory_clobber() used to support CW style ASM statements
in Apple version of GCC. CW Style ASM statements are not
supported in FSF GCC.

-
Devang


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [patch] fix gcc build failure on arm

Chris Lattner
In reply to this post by Rafael Espíndola
On Tue, 3 Oct 2006, [UTF-8] Rafael Esp?ndola wrote:
> The attached patch implements iasm_memory_clobber so that cc1 links
> correctly on arm targets.

I applied this patch to llvm-gcc, hopefully it will fix building on all
non-darwin platforms.  It looks like this patch got lost in a recent
merge.  I will try to get this fixed upstream so this doesn't occur next
merge.

Thanks!

-Chris


Index: c-common.c
===================================================================
--- c-common.c  (revision 118526)
+++ c-common.c  (working copy)
@@ -7184,6 +7184,8 @@
    sexpr = build_string (strlen (iasm_buffer), iasm_buffer);

    clobbers = uses;
+  /* APPLE LOCAL LLVM portability to other platforms! */
+#ifdef TARGET_MACHO
    if (iasm_memory_clobber (opcodename))
      {
        /* To not clobber all of memory, we would need to know what
@@ -7192,6 +7194,8 @@
                             build_string (6, "memory"),
                             clobbers);
      }
+  /* APPLE LOCAL LLVM portability to other platforms! */
+#endif

    /* Perform default conversions on function inputs.
       Don't do this for other types as it would screw up operands

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev