new warnings in r58273

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

new warnings in r58273

Mike Stump
llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp: In member  
function ‘void llvm::SelectionDAG::setSubgraphColor(llvm::SDNode*,  
const char*)’:
llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp:372:  
warning: comparison with string literal results in unspecified behavior
llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp:375:  
warning: comparison with string literal results in unspecified behavior

from:

     if (Color == "red" ) {
       setSubgraphColorHelper(N, "blue", visited, 0, printed);
     }
     else if (Color == "yellow" ) {

:-(
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: new warnings in r58273

dag-7
On Monday 27 October 2008 17:06, Mike Stump wrote:

> llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp: In member
> function ‘void llvm::SelectionDAG::setSubgraphColor(llvm::SDNode*,
> const char*)’:
> llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp:372:
> warning: comparison with string literal results in unspecified behavior
> llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp:375:
> warning: comparison with string literal results in unspecified behavior
>
> from:
>
>      if (Color == "red" ) {
>        setSubgraphColorHelper(N, "blue", visited, 0, printed);
>      }
>      else if (Color == "yellow" ) {

Will fix.

                                            -Dave

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: new warnings in r58273

Ted Kremenek-2
I think I already fixed this one.

On Oct 27, 2008, at 3:19 PM, David Greene wrote:

> On Monday 27 October 2008 17:06, Mike Stump wrote:
>> llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp: In member
>> function ‘void llvm::SelectionDAG::setSubgraphColor(llvm::SDNode*,
>> const char*)’:
>> llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp:372:
>> warning: comparison with string literal results in unspecified  
>> behavior
>> llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp:375:
>> warning: comparison with string literal results in unspecified  
>> behavior
>>
>> from:
>>
>>     if (Color == "red" ) {
>>       setSubgraphColorHelper(N, "blue", visited, 0, printed);
>>     }
>>     else if (Color == "yellow" ) {
>
> Will fix.
>
>                                            -Dave
>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev