[llvm-dev] llvm-mc-assemble-fuzzer broken

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[llvm-dev] llvm-mc-assemble-fuzzer broken

Dean Michael Berris via llvm-dev
While playing with sanitizer in a downstream project, I found out this.

/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:207:32:
error: reference to type 'std::unique_ptr<MCCodeEmitter>' could not
bind to an
 lvalue of type 'llvm::MCCodeEmitter *'
        UseDwarfDirectory, IP, CE, MAB, ShowInst));
                               ^~
/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:514:66:
note: passing argument to parameter 'CE' here
                                std::unique_ptr<MCCodeEmitter> &&CE,
                                                                 ^
/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:232:55:
error: too many arguments to function call, expected 3, have 4
                                                      MCOptions);
                                                      ^~~~~~~~~
/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:401:3:
note: 'createMCAsmBackend' declared here
  MCAsmBackend *createMCAsmBackend(const MCSubtargetInfo &STI,
  ^
2 errors generated.

Apparently, this has been broken for several months. I think I can fix
this particular instance, but I was wondering whether anybody cares
about this tool?

--
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare
_______________________________________________
LLVM Developers mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] llvm-mc-assemble-fuzzer broken

Dean Michael Berris via llvm-dev
It worked in August.
Last time I’ve asked (again, in August) someone did seem to care,
but it is inevitable it would bitrot if it’s not built in any of the bots.

George

> On May 4, 2018, at 2:53 PM, Davide Italiano via llvm-dev <[hidden email]> wrote:
>
> While playing with sanitizer in a downstream project, I found out this.
>
> /Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:207:32:
> error: reference to type 'std::unique_ptr<MCCodeEmitter>' could not
> bind to an
> lvalue of type 'llvm::MCCodeEmitter *'
>        UseDwarfDirectory, IP, CE, MAB, ShowInst));
>                               ^~
> /Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:514:66:
> note: passing argument to parameter 'CE' here
>                                std::unique_ptr<MCCodeEmitter> &&CE,
>                                                                 ^
> /Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:232:55:
> error: too many arguments to function call, expected 3, have 4
>                                                      MCOptions);
>                                                      ^~~~~~~~~
> /Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:401:3:
> note: 'createMCAsmBackend' declared here
>  MCAsmBackend *createMCAsmBackend(const MCSubtargetInfo &STI,
>  ^
> 2 errors generated.
>
> Apparently, this has been broken for several months. I think I can fix
> this particular instance, but I was wondering whether anybody cares
> about this tool?
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
LLVM Developers mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] llvm-mc-assemble-fuzzer broken

Dean Michael Berris via llvm-dev
Thank you.
I went ahead with a speculative fix in r331568.
I'm not familiar _at all_ with the tool, so, although the fix was
straightforward, another pair of eyes from somebody familiar with the
tool would be appreciated.

On Fri, May 4, 2018 at 5:10 PM, George Karpenkov <[hidden email]> wrote:

> It worked in August.
> Last time I’ve asked (again, in August) someone did seem to care,
> but it is inevitable it would bitrot if it’s not built in any of the bots.
>
> George
>
>> On May 4, 2018, at 2:53 PM, Davide Italiano via llvm-dev <[hidden email]> wrote:
>>
>> While playing with sanitizer in a downstream project, I found out this.
>>
>> /Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:207:32:
>> error: reference to type 'std::unique_ptr<MCCodeEmitter>' could not
>> bind to an
>> lvalue of type 'llvm::MCCodeEmitter *'
>>        UseDwarfDirectory, IP, CE, MAB, ShowInst));
>>                               ^~
>> /Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:514:66:
>> note: passing argument to parameter 'CE' here
>>                                std::unique_ptr<MCCodeEmitter> &&CE,
>>                                                                 ^
>> /Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:232:55:
>> error: too many arguments to function call, expected 3, have 4
>>                                                      MCOptions);
>>                                                      ^~~~~~~~~
>> /Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:401:3:
>> note: 'createMCAsmBackend' declared here
>>  MCAsmBackend *createMCAsmBackend(const MCSubtargetInfo &STI,
>>  ^
>> 2 errors generated.
>>
>> Apparently, this has been broken for several months. I think I can fix
>> this particular instance, but I was wondering whether anybody cares
>> about this tool?
>>
>> --
>> Davide
>>
>> "There are no solved problems; there are only problems that are more
>> or less solved" -- Henri Poincare
>> _______________________________________________
>> LLVM Developers mailing list
>> [hidden email]
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>



--
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare
_______________________________________________
LLVM Developers mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] llvm-mc-assemble-fuzzer broken

Dean Michael Berris via llvm-dev
rL331568 looks good to me.

On 4 May 2018, at 17:17, Davide Italiano via llvm-dev <[hidden email]> wrote:

Thank you.
I went ahead with a speculative fix in r331568.
I'm not familiar _at all_ with the tool, so, although the fix was
straightforward, another pair of eyes from somebody familiar with the
tool would be appreciated.

On Fri, May 4, 2018 at 5:10 PM, George Karpenkov <[hidden email]> wrote:
It worked in August.
Last time I’ve asked (again, in August) someone did seem to care,
but it is inevitable it would bitrot if it’s not built in any of the bots.

That was me. I still have a task on my todo list to set up a bot for this but it keeps being pushed back by other priorities.

George

On May 4, 2018, at 2:53 PM, Davide Italiano via llvm-dev <[hidden email]> wrote:

While playing with sanitizer in a downstream project, I found out this.

/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:207:32:
error: reference to type 'std::unique_ptr<MCCodeEmitter>' could not
bind to an
lvalue of type 'llvm::MCCodeEmitter *'
      UseDwarfDirectory, IP, CE, MAB, ShowInst));
                             ^~
/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:514:66:
note: passing argument to parameter 'CE' here
                              std::unique_ptr<MCCodeEmitter> &&CE,
                                                               ^
/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp:232:55:
error: too many arguments to function call, expected 3, have 4
                                                    MCOptions);
                                                    ^~~~~~~~~
/Users/davide/work/llvm-monorepo/llvm-project-20170507/llvm/include/llvm/Support/TargetRegistry.h:401:3:
note: 'createMCAsmBackend' declared here
MCAsmBackend *createMCAsmBackend(const MCSubtargetInfo &STI,
^
2 errors generated.

Apparently, this has been broken for several months. I think I can fix
this particular instance, but I was wondering whether anybody cares
about this tool?

--
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare
_______________________________________________
LLVM Developers mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev




-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare
_______________________________________________
LLVM Developers mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev


_______________________________________________
LLVM Developers mailing list
[hidden email]
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev