[llvm-dev] [compiler-rt] InstrProfData.inc duplicate

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[llvm-dev] [compiler-rt] InstrProfData.inc duplicate

David Blaikie via llvm-dev
Hi. We have two identical files "InstrProfData.inc"

$ diff compiler-rt/include/profile/InstrProfData.inc llvm/include/llvm/ProfileData/InstrProfData.inc
$

These files have a description without mentioning the reason of such duplication:
* The file has two identical copies. The master copy lives in LLVM and
* the other one sits in compiler-rt/lib/profile directory. To make changes
* in this file, first modify the master copy and copy it over to compiler-rt.
* Testing of any change in this file can start only after the two copies are
* synced up.

I just wondering if there is a reason why we cannot remove one of these files and do something like this:

diff --git a/compiler-rt/lib/profile/InstrProfiling.c b/compiler-rt/lib/profile/InstrProfiling.c
index 31a9fe99629..355ade1960e 100644
--- a/compiler-rt/lib/profile/InstrProfiling.c
+++ b/compiler-rt/lib/profile/InstrProfiling.c
@@ -15,7 +15,7 @@
 #include "InstrProfilingInternal.h"
 
 #define INSTR_PROF_VALUE_PROF_DATA
-#include "profile/InstrProfData.inc"
+#include "llvm/ProfileData/InstrProfData.inc"


Thank you
Pavel

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev