[llvm-dev] MIssing llvm-commits messages

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[llvm-dev] MIssing llvm-commits messages

Jeremy Morse via llvm-dev
Has anyone noticed missing llvm-commits messages?  Not all commits seem to generate emails to llvm-commits.

For example, I can’t find an email for this commit:  https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070



_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] MIssing llvm-commits messages

Jeremy Morse via llvm-dev
Yep, there seems to be an issue with commits containing non-ASCII
symbols (in Author: line?)

On Tue, Dec 10, 2019 at 12:08 AM Don Hinton via llvm-dev
<[hidden email]> wrote:
>
> Has anyone noticed missing llvm-commits messages?  Not all commits seem to generate emails to llvm-commits.
>
> For example, I can’t find an email for this commit:  https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070
>
> Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html

Roman

> _______________________________________________
> LLVM Developers mailing list
> [hidden email]
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] MIssing llvm-commits messages

Jeremy Morse via llvm-dev


> On Dec 9, 2019, at 1:10 PM, Roman Lebedev <[hidden email]> wrote:
>
> Yep, there seems to be an issue with commits containing non-ASCII
> symbols (in Author: line?)

Ah, perhaps, but I don’t seen anything obvious, at least not in the log.  And the author has other commits just before and after that did generate a messages, so it seems somewhat random to me.

>
> On Tue, Dec 10, 2019 at 12:08 AM Don Hinton via llvm-dev
> <[hidden email]> wrote:
>>
>> Has anyone noticed missing llvm-commits messages?  Not all commits seem to generate emails to llvm-commits.
>>
>> For example, I can’t find an email for this commit:  https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070
>>
>> Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html
>
> Roman
>
>> _______________________________________________
>> LLVM Developers mailing list
>> [hidden email]
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] MIssing llvm-commits messages

Jeremy Morse via llvm-dev
I noticed a similar thing back in August:  http://lists.llvm.org/pipermail/llvm-dev/2019-August/134516.html

Russ

On Mon, 9 Dec 2019 at 22:19, Don Hinton via llvm-dev <[hidden email]> wrote:


> On Dec 9, 2019, at 1:10 PM, Roman Lebedev <[hidden email]> wrote:
>
> Yep, there seems to be an issue with commits containing non-ASCII
> symbols (in Author: line?)

Ah, perhaps, but I don’t seen anything obvious, at least not in the log.  And the author has other commits just before and after that did generate a messages, so it seems somewhat random to me.

>
> On Tue, Dec 10, 2019 at 12:08 AM Don Hinton via llvm-dev
> <[hidden email]> wrote:
>>
>> Has anyone noticed missing llvm-commits messages?  Not all commits seem to generate emails to llvm-commits.
>>
>> For example, I can’t find an email for this commit:  https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070
>>
>> Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html
>
> Roman
>
>> _______________________________________________
>> LLVM Developers mailing list
>> [hidden email]
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] MIssing llvm-commits messages

Jeremy Morse via llvm-dev
(CC llvm-commits-owner and llvm-admin)

Here's another previous thread on the subject of unicode characters in commit logs:  http://lists.llvm.org/pipermail/llvm-dev/2019-November/137290.html

But as Don points out, this particular case appears to be something different, unless there's something hiding in that commit which I'm not spotting.

-Greg

On Tue, 10 Dec 2019 at 10:36, Russell Gallop via llvm-dev <[hidden email]> wrote:
I noticed a similar thing back in August:  http://lists.llvm.org/pipermail/llvm-dev/2019-August/134516.html

Russ

On Mon, 9 Dec 2019 at 22:19, Don Hinton via llvm-dev <[hidden email]> wrote:


> On Dec 9, 2019, at 1:10 PM, Roman Lebedev <[hidden email]> wrote:
>
> Yep, there seems to be an issue with commits containing non-ASCII
> symbols (in Author: line?)

Ah, perhaps, but I don’t seen anything obvious, at least not in the log.  And the author has other commits just before and after that did generate a messages, so it seems somewhat random to me.

>
> On Tue, Dec 10, 2019 at 12:08 AM Don Hinton via llvm-dev
> <[hidden email]> wrote:
>>
>> Has anyone noticed missing llvm-commits messages?  Not all commits seem to generate emails to llvm-commits.
>>
>> For example, I can’t find an email for this commit:  https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070
>>
>> Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html
>
> Roman
>
>> _______________________________________________
>> LLVM Developers mailing list
>> [hidden email]
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] MIssing llvm-commits messages

Jeremy Morse via llvm-dev
In reply to this post by Jeremy Morse via llvm-dev
On 12/09/2019 01:07 PM, Don Hinton via llvm-dev wrote:
> Has anyone noticed missing llvm-commits messages?  Not all commits seem to generate emails to llvm-commits.
>
> For example, I can’t find an email for this commit:  https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070
>

It looks like this commit was part of a push that contained 2 commits.
Our mailer script was supposed to be able to handle this case, but
it's possible there is a bug.

When we were setting up the email, we did notice 1 missed email
due to the webhook not being initiated from the GitHub side, but
this is not the case here.

-Tom


> Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] MIssing llvm-commits messages

Jeremy Morse via llvm-dev
On Tue, Dec 10, 2019 at 1:02 PM Tom Stellard via llvm-dev
<[hidden email]> wrote:

>
> On 12/09/2019 01:07 PM, Don Hinton via llvm-dev wrote:
> > Has anyone noticed missing llvm-commits messages?  Not all commits seem to generate emails to llvm-commits.
> >
> > For example, I can’t find an email for this commit:  https://github.com/llvm/llvm-project/commit/4a6e13ad88ddcc0ab92ace49d4c761921e7f7070
> >
>
> It looks like this commit was part of a push that contained 2 commits.
> Our mailer script was supposed to be able to handle this case, but
> it's possible there is a bug.
>
> When we were setting up the email, we did notice 1 missed email
> due to the webhook not being initiated from the GitHub side, but
> this is not the case here.

Here is another commit that looks like it never made it to the list:
https://github.com/llvm/llvm-project/commit/5ee616a710bcb52cf9f1f7951644d098d38e7b6a#diff-b6b80c09b0caab74eede5945b15f16edR34

It also has unicode characters in the commit log.

~Aaron


>
> -Tom
>
>
> > Nor does it appear here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20191209/date.html
> >
> >
> >
> > _______________________________________________
> > LLVM Developers mailing list
> > [hidden email]
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> >
>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev