[llvm-dev] How to submit a change for code review using arc

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[llvm-dev] How to submit a change for code review using arc

Peter Smith via llvm-dev
I've gone through Code Reviews with Phabriactor[1], Arcanist Quick
Start[2] and Arcanist User Guide arc diff[3]. But I'm unable to setup
reviewers my editor pops up and there is a "Reviewers:" line and but
I'm unable email addresses directly. It seems it wants reviewers
passed on the command line or some how in .arcconfig.

But I haven't been able to find any documentation on how to setup
reviewers so I've guessed you can add it to .git/arc/config:

What I've got now is my .git/arc/config is:
 {
  "editor": "vim",
  "reviewers": {
    "peterc": "[hidden email]",
    "evgeniys": "[hidden email]",
    "llvm-commits": "[hidden email]"
   }
 }

My commit message is:
 $ git log -1
 commit f04a938e5ad72afbf64242718d456fa480ad5f6b (HEAD ->
compiler-rt-fix-cmake-warnings)
 Author: Wink Saville <[hidden email]>
 Date:   Tue Apr 23 16:55:21 2019 -0700

    [compiler-rt] Fix cmake warnings

    Summary:
    - Fix cmake BOOL misspellings
    - Set cmake policy for CMP0075 to NEW

    Reviewers: peterc, evgeniys

    Subscribers: llvm-commits

The result of "arc diff master" is:
 $ arc diff master
 You have untracked files in this working copy.

 Working copy: /home/wink/prgs/llvm/llvm-project/

 Commit message has errors:

      - Error parsing field "Reviewers": The objects you have listed include
      objects which do not exist (peterc, evgeniys).

 You must resolve these errors to continue.

    Do you want to edit the message? [Y/n] n

 Usage Exception: Message has unresolved errors.

Help appreciated.

[1]: https://llvm.org/docs/Phabricator.html
[2]: https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/
[3]: https://secure.phabricator.com/book/phabricator/article/arcanist_diff/
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] How to submit a change for code review using arc

Peter Smith via llvm-dev
The username has to exist on phabricator:
https://reviews.llvm.org/p/peterc/   -> 404
https://reviews.llvm.org/p/evgeniys/ -> 404

I'm guessing you want:
https://reviews.llvm.org/p/daemon/ -> Evgeniy
https://reviews.llvm.org/p/pcc/ -> Peter Collingbourne


---------------------------------------
Johannes Doerfert
Researcher

Argonne National Laboratory
Lemont, IL 60439, USA

[hidden email]

________________________________________
From: llvm-dev <[hidden email]> on behalf of Wink Saville via llvm-dev <[hidden email]>
Sent: Thursday, April 25, 2019 22:08
To: llvm-dev
Subject: [llvm-dev] How to submit a change for code review using arc

I've gone through Code Reviews with Phabriactor[1], Arcanist Quick
Start[2] and Arcanist User Guide arc diff[3]. But I'm unable to setup
reviewers my editor pops up and there is a "Reviewers:" line and but
I'm unable email addresses directly. It seems it wants reviewers
passed on the command line or some how in .arcconfig.

But I haven't been able to find any documentation on how to setup
reviewers so I've guessed you can add it to .git/arc/config:

What I've got now is my .git/arc/config is:
 {
  "editor": "vim",
  "reviewers": {
    "peterc": "[hidden email]",
    "evgeniys": "[hidden email]",
    "llvm-commits": "[hidden email]"
   }
 }

My commit message is:
 $ git log -1
 commit f04a938e5ad72afbf64242718d456fa480ad5f6b (HEAD ->
compiler-rt-fix-cmake-warnings)
 Author: Wink Saville <[hidden email]>
 Date:   Tue Apr 23 16:55:21 2019 -0700

    [compiler-rt] Fix cmake warnings

    Summary:
    - Fix cmake BOOL misspellings
    - Set cmake policy for CMP0075 to NEW

    Reviewers: peterc, evgeniys

    Subscribers: llvm-commits

The result of "arc diff master" is:
 $ arc diff master
 You have untracked files in this working copy.

 Working copy: /home/wink/prgs/llvm/llvm-project/

 Commit message has errors:

      - Error parsing field "Reviewers": The objects you have listed include
      objects which do not exist (peterc, evgeniys).

 You must resolve these errors to continue.

    Do you want to edit the message? [Y/n] n

 Usage Exception: Message has unresolved errors.

Help appreciated.

[1]: https://llvm.org/docs/Phabricator.html
[2]: https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/
[3]: https://secure.phabricator.com/book/phabricator/article/arcanist_diff/
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] How to submit a change for code review using arc

Peter Smith via llvm-dev
On Thu, Apr 25, 2019 at 8:32 PM Doerfert, Johannes <[hidden email]> wrote:
>
> The username has to exist on phabricator:
> https://reviews.llvm.org/p/peterc/   -> 404
> https://reviews.llvm.org/p/evgeniys/ -> 404
>
> I'm guessing you want:
> https://reviews.llvm.org/p/daemon/ -> Evgeniy
> https://reviews.llvm.org/p/pcc/ -> Peter Collingbourne

Thanks, using daemon and pcc worked. I must say the documentation I
found wasn't helpful, so thanks for the prompt reply!!
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] How to submit a change for code review using arc

Peter Smith via llvm-dev
Hi Wink:

On Fri, Apr 26, 2019 at 10:53 AM Wink Saville via llvm-dev <[hidden email]> wrote:
On Thu, Apr 25, 2019 at 8:32 PM Doerfert, Johannes <[hidden email]> wrote:
>
> The username has to exist on phabricator:
> https://reviews.llvm.org/p/peterc/   -> 404
> https://reviews.llvm.org/p/evgeniys/ -> 404
>
> I'm guessing you want:
> https://reviews.llvm.org/p/daemon/ -> Evgeniy
> https://reviews.llvm.org/p/pcc/ -> Peter Collingbourne

Thanks, using daemon and pcc worked. I must say the documentation I
found wasn't helpful, so thanks for the prompt reply!!

While it's still fresh in your mind, you might consider updating https://llvm.org/docs/Phabricator.html (which is llvm/docs/Phabricator.rst) based on your experience,
which will make it easier for future contributors.  I guess the main issue is getting used to the fact that Phabricator user names are independent and must be looked up on the web site -- at least I haven't found any other way -- but that isn't spelled out anywhere.

thanks again...
don
 
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] How to submit a change for code review using arc

Peter Smith via llvm-dev
> While it's still fresh in your mind, you might consider updating https://llvm.org/docs/Phabricator.html (which is llvm/docs/Phabricator.rst) based on your experience,
> which will make it easier for future contributors.  I guess the main issue is getting used to the fact that Phabricator user names are independent and must be looked up on the web site -- at least I haven't found any other way -- but that isn't spelled out anywhere.
>
> thanks again...
> don

Yes I'll see what I can do to improve the documentation.

Since github seems to be a well known workflow and seems to work OK,
it would be nice if that could be used. Is anyone working on that?

Is there an RFC or some such on what are the requirements for code
reviews/pull requests?

-- Wink
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] How to submit a change for code review using arc

Peter Smith via llvm-dev
On Sat, Apr 27, 2019 at 5:53 PM Wink Saville <[hidden email]> wrote:
> While it's still fresh in your mind, you might consider updating https://llvm.org/docs/Phabricator.html (which is llvm/docs/Phabricator.rst) based on your experience,
> which will make it easier for future contributors.  I guess the main issue is getting used to the fact that Phabricator user names are independent and must be looked up on the web site -- at least I haven't found any other way -- but that isn't spelled out anywhere.
>
> thanks again...
> don

Yes I'll see what I can do to improve the documentation.

Since github seems to be a well known workflow and seems to work OK,
it would be nice if that could be used. Is anyone working on that?

Is there an RFC or some such on what are the requirements for code
reviews/pull requests?

Not sure if this is what you mean, but here's a current thread you may find interesting.


hth...
don
 

-- Wink

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] How to submit a change for code review using arc

Peter Smith via llvm-dev
On Sat, Apr 27, 2019 at 7:10 PM Don Hinton <[hidden email]> wrote:

>
> On Sat, Apr 27, 2019 at 5:53 PM Wink Saville <[hidden email]> wrote:
>>
>> > While it's still fresh in your mind, you might consider updating https://llvm.org/docs/Phabricator.html (which is llvm/docs/Phabricator.rst) based on your experience,
>> > which will make it easier for future contributors.  I guess the main issue is getting used to the fact that Phabricator user names are independent and must be looked up on the web site -- at least I haven't found any other way -- but that isn't spelled out anywhere.
>> >
>> > thanks again...
>> > don
>>
>> Yes I'll see what I can do to improve the documentation.
>>
>> Since github seems to be a well known workflow and seems to work OK,
>> it would be nice if that could be used. Is anyone working on that?
>>
>> Is there an RFC or some such on what are the requirements for code
>> reviews/pull requests?
>
>
> Not sure if this is what you mean, but here's a current thread you may find interesting.
>
> https://lists.llvm.org/pipermail/llvm-dev/2019-March/131135.html
>
> hth...
> don
>

Yep, that's looks like it, txs.
_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev