[llvm-dev] Bugzilla OrcJIT Tickets

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[llvm-dev] Bugzilla OrcJIT Tickets

Shawn Webb via llvm-dev
Hello everyone

A previous thread about OrcJIT brought up bug reports on Bugzilla. A
quick search gives 20+ results:
https://bugs.llvm.org/buglist.cgi?component=OrcJIT&list_id=162232&query_format=advanced&resolution=---

While some of them are obviously outdated (addModuleSet API cleanup
[1]), others may actually be relevant again (Small code model? [2]). If
you reported one of them, please take the time (some day) and review
from today's perspective.

Are there recommendations regarding Bugzilla reports from other parts of
LLVM? Best practices that worked out well?

Thanks!
Stefan

--

[1] https://bugs.llvm.org/show_bug.cgi?id=30896
[2] https://bugs.llvm.org/show_bug.cgi?id=24159

--
https://flowcrypt.com/pub/stefan.graenitz@...



_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

[llvm-dev] Fwd: Bugzilla OrcJIT Tickets

Shawn Webb via llvm-dev

In fact, this is all very good practice in my opinion:
https://bugs.llvm.org/show_bug.cgi?id=30896
https://bugs.llvm.org/show_bug.cgi?id=22608
https://bugs.llvm.org/show_bug.cgi?id=24159

Back in 2016 I simply didn't know about the Bugzilla tracker.
From today's perspective, I think, we should try and revive this spirit and share rough plans there.

@Praveen very good initiative!
https://bugs.llvm.org/show_bug.cgi?id=41075

@Machiel: This is quite recent, but didn't land after it was accepted. Objections?
https://reviews.llvm.org/D61599

Cheers

-------- Forwarded Message --------
Subject: Bugzilla OrcJIT Tickets
Date: Sat, 18 May 2019 17:47:58 +0200
From: Stefan Gränitz [hidden email]
To: via llvm-dev [hidden email]


Hello everyone

A previous thread about OrcJIT brought up bug reports on Bugzilla. A
quick search gives 20+ results:
https://bugs.llvm.org/buglist.cgi?component=OrcJIT&list_id=162232&query_format=advanced&resolution=---

While some of them are obviously outdated (addModuleSet API cleanup
[1]), others may actually be relevant again (Small code model? [2]). If
you reported one of them, please take the time (some day) and review
from today's perspective.

Are there recommendations regarding Bugzilla reports from other parts of
LLVM? Best practices that worked out well?

Thanks!
Stefan

--

[1] https://bugs.llvm.org/show_bug.cgi?id=30896
[2] https://bugs.llvm.org/show_bug.cgi?id=24159

-- 
https://flowcrypt.com/pub/stefan.graenitz@...




_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] Bugzilla OrcJIT Tickets

Shawn Webb via llvm-dev
Hi Stefan
Thank you!
In case, you missed in llvm-dev listing: you can find the proposal here : link.
Thanks for working on summarising the Bugzilla tickets to track the recent changes in ORC this is really helpful.


On Sat, 18 May 2019 at 21:33, Stefan Gränitz <[hidden email]> wrote:

In fact, this is all very good practice in my opinion:
https://bugs.llvm.org/show_bug.cgi?id=30896
https://bugs.llvm.org/show_bug.cgi?id=22608
https://bugs.llvm.org/show_bug.cgi?id=24159

Back in 2016 I simply didn't know about the Bugzilla tracker.
From today's perspective, I think, we should try and revive this spirit and share rough plans there.

@Praveen very good initiative!
https://bugs.llvm.org/show_bug.cgi?id=41075

@Machiel: This is quite recent, but didn't land after it was accepted. Objections?
https://reviews.llvm.org/D61599

Cheers

-------- Forwarded Message --------
Subject: Bugzilla OrcJIT Tickets
Date: Sat, 18 May 2019 17:47:58 +0200
From: Stefan Gränitz [hidden email]
To: via llvm-dev [hidden email]


Hello everyone

A previous thread about OrcJIT brought up bug reports on Bugzilla. A
quick search gives 20+ results:
https://bugs.llvm.org/buglist.cgi?component=OrcJIT&list_id=162232&query_format=advanced&resolution=---

While some of them are obviously outdated (addModuleSet API cleanup
[1]), others may actually be relevant again (Small code model? [2]). If
you reported one of them, please take the time (some day) and review
from today's perspective.

Are there recommendations regarding Bugzilla reports from other parts of
LLVM? Best practices that worked out well?

Thanks!
Stefan

--

[1] https://bugs.llvm.org/show_bug.cgi?id=30896
[2] https://bugs.llvm.org/show_bug.cgi?id=24159

-- 
https://flowcrypt.com/pub/stefan.graenitz@...




_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] Bugzilla OrcJIT Tickets

Shawn Webb via llvm-dev
In reply to this post by Shawn Webb via llvm-dev
Hi Stefan,

As for https://reviews.llvm.org/D61599 ,  I do not have commit access so I am waiting for Lang or someone else to commit this patch.
This fixes https://bugs.llvm.org/show_bug.cgi?id=41690 .

I can also confirm that this other bug that I reported a while ago is still relevant with ORCv2: https://bugs.llvm.org/show_bug.cgi?id=40074
It is a rather impactful one on COFF/Windows. There is an effective workaround though.
The COFF side of ORC still needs a few other workarounds to be enabled for it to work properly. It could use some more developer attention.
One off them I believe is a workaround for https://bugs.llvm.org/show_bug.cgi?id=25493, so that one is still relevant as well.
I might contribute some more patches in that direction in the future if I can find the time, though I have limited experience with llvm.

Cheers
Machiel


On Sat, May 18, 2019 at 6:03 PM Stefan Gränitz <[hidden email]> wrote:

In fact, this is all very good practice in my opinion:
https://bugs.llvm.org/show_bug.cgi?id=30896
https://bugs.llvm.org/show_bug.cgi?id=22608
https://bugs.llvm.org/show_bug.cgi?id=24159

Back in 2016 I simply didn't know about the Bugzilla tracker.
From today's perspective, I think, we should try and revive this spirit and share rough plans there.

@Praveen very good initiative!
https://bugs.llvm.org/show_bug.cgi?id=41075

@Machiel: This is quite recent, but didn't land after it was accepted. Objections?
https://reviews.llvm.org/D61599

Cheers

-------- Forwarded Message --------
Subject: Bugzilla OrcJIT Tickets
Date: Sat, 18 May 2019 17:47:58 +0200
From: Stefan Gränitz [hidden email]
To: via llvm-dev [hidden email]


Hello everyone

A previous thread about OrcJIT brought up bug reports on Bugzilla. A
quick search gives 20+ results:
https://bugs.llvm.org/buglist.cgi?component=OrcJIT&list_id=162232&query_format=advanced&resolution=---

While some of them are obviously outdated (addModuleSet API cleanup
[1]), others may actually be relevant again (Small code model? [2]). If
you reported one of them, please take the time (some day) and review
from today's perspective.

Are there recommendations regarding Bugzilla reports from other parts of
LLVM? Best practices that worked out well?

Thanks!
Stefan

--

[1] https://bugs.llvm.org/show_bug.cgi?id=30896
[2] https://bugs.llvm.org/show_bug.cgi?id=24159

-- 
https://flowcrypt.com/pub/stefan.graenitz@...




_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-dev] Bugzilla OrcJIT Tickets

Shawn Webb via llvm-dev
In reply to this post by Shawn Webb via llvm-dev
Thanks for your attention! We found 7 outdated issues and reviewed 8 more that now describe a way forward.
This was a good step towards overview :)

The remaining long-standing reports gather around 2 hotspots:

Missing functionality and workarounds on Windows: llvm.org/PR25493, llvm.org/PR41595
In my experience the Windows incompatibilities are hard to tackle. I am not surprised having a number of permanent tickets there.

C-API bindings: llvm.org/PR31101, llvm.org/PR31103, llvm.org/PR32628, llvm.org/PR36896

Maybe this is worth a discussion, as I have seen people confused (and I am not up-to-date either):
* Are the C-bindings meant to be functional for OrcV1 and OrcV2?
* Do they provide full or partial functionality?
* Which parts work, which don't?

Best
Stefan

On 5/18/19 8:02 PM, Praveen Velliengiri wrote:

Hi Stefan
Thank you!
In case, you missed in llvm-dev listing: you can find the proposal here : link.
Thanks for working on summarising the Bugzilla tickets to track the recent changes in ORC this is really helpful.


On Sat, 18 May 2019 at 21:33, Stefan Gränitz <[hidden email]> wrote:

In fact, this is all very good practice in my opinion:
https://bugs.llvm.org/show_bug.cgi?id=30896
https://bugs.llvm.org/show_bug.cgi?id=22608
https://bugs.llvm.org/show_bug.cgi?id=24159

Back in 2016 I simply didn't know about the Bugzilla tracker.
From today's perspective, I think, we should try and revive this spirit and share rough plans there.

@Praveen very good initiative!
https://bugs.llvm.org/show_bug.cgi?id=41075

@Machiel: This is quite recent, but didn't land after it was accepted. Objections?
https://reviews.llvm.org/D61599

Cheers

-------- Forwarded Message --------
Subject: Bugzilla OrcJIT Tickets
Date: Sat, 18 May 2019 17:47:58 +0200
From: Stefan Gränitz [hidden email]
To: via llvm-dev [hidden email]


Hello everyone

A previous thread about OrcJIT brought up bug reports on Bugzilla. A
quick search gives 20+ results:
https://bugs.llvm.org/buglist.cgi?component=OrcJIT&list_id=162232&query_format=advanced&resolution=---

While some of them are obviously outdated (addModuleSet API cleanup
[1]), others may actually be relevant again (Small code model? [2]). If
you reported one of them, please take the time (some day) and review
from today's perspective.

Are there recommendations regarding Bugzilla reports from other parts of
LLVM? Best practices that worked out well?

Thanks!
Stefan

--

[1] https://bugs.llvm.org/show_bug.cgi?id=30896
[2] https://bugs.llvm.org/show_bug.cgi?id=24159

-- 
https://flowcrypt.com/pub/stefan.graenitz@...



-- 
https://flowcrypt.com/pub/stefan.graenitz@...

_______________________________________________
LLVM Developers mailing list
[hidden email]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

signature.asc (499 bytes) Download Attachment