[lld] Patch to incorporate lld test-suite into "make check-all"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[lld] Patch to incorporate lld test-suite into "make check-all"

Andy Gibbs
Hi,

Attached is a patch which incorporates the lld test-suite into llvm's "make check-all" if lld is built within llvm.  Please could someone review this for me.

I've hand-amended the patch so that it should be easier to review.  The majority of the patch is simply changing the indent once inside and else()/endif() block.  Beyond that, I've standardised the test target name to "check-lld", but retained the legacy "lld-test" target.

Regards
Andy


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

lld-tests.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [lld] Patch to incorporate lld test-suite into "make check-all"

Andy Gibbs
On Thursday, July 26, 2012 1:45 PM, Andy Gibbs wrote:
> Attached is a patch which incorporates the lld test-suite
> into llvm's "make check-all" if lld is built within llvm.
> Please could someone review this for me.

Sorry, I missed a dependency.  Here is an additional patch for
the additional dependency:

Index: tools/lld/test/CMakeLists.txt
==================================================================
--- tools/lld/test/CMakeLists.txt
+++ tools/lld/test/CMakeLists.txt
@@ -17,11 +17,11 @@
 
 if ( NOT LLD_BUILT_STANDALONE )
 
   set(LLD_TEST_DEPS
     lld-core lld-test.deps
-    FileCheck not
+    FileCheck not llvm-nm
     )
   set(LLD_TEST_PARAMS
     lld_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
     )
 



_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [lld] Patch to incorporate lld test-suite into "make check-all"

Andy Gibbs
In reply to this post by Andy Gibbs
Hi again,

Any interest in this patch to incorporate lld testing into "make check-all"
when lld built as part of llvm?  Is this the best place to post patches for
lld?

I've attached it again here to include a missing dependency.

Cheers
Andy


On Thursday, July 26, 2012 1:45 PM, Andy Gibbs wrote:

> Hi,
>
> Attached is a patch which incorporates the lld test-suite into llvm's "make
> check-all" if lld is built within llvm.  Please could someone review this
> for me.
>
> I've hand-amended the patch so that it should be easier to review.  The
> majority of the patch is simply changing the indent once inside and else()/
> endif() block.  Beyond that, I've standardised the test target name to
> "check-lld", but retained the legacy "lld-test" target.
>
> Regards
> Andy

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

lld-tests.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [lld] Patch to incorporate lld test-suite into "make check-all"

Michael Spencer-4
On Tue, Jul 31, 2012 at 2:35 AM, Andy Gibbs <[hidden email]> wrote:

> Hi again,
>
> Any interest in this patch to incorporate lld testing into "make check-all"
> when lld built as part of llvm?  Is this the best place to post patches for
> lld?
>
> I've attached it again here to include a missing dependency.
>
> Cheers
> Andy
>
>
> On Thursday, July 26, 2012 1:45 PM, Andy Gibbs wrote:
>> Hi,
>>
>> Attached is a patch which incorporates the lld test-suite into llvm's "make
>> check-all" if lld is built within llvm.  Please could someone review this
>> for me.
>>
>> I've hand-amended the patch so that it should be easier to review.  The
>> majority of the patch is simply changing the indent once inside and else()/
>> endif() block.  Beyond that, I've standardised the test target name to
>> "check-lld", but retained the legacy "lld-test" target.
>>
>> Regards
>> Andy

Committed as r161067. Thanks!

Can you create futures patches relative to the lld directory instead
of llvm? I don't have lld checked out inside llvm.

- Michael Spencer
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [lld] Patch to incorporate lld test-suite into "make check-all"

Andy Gibbs
On Tuesday, July 31, 2012 8:46 PM, Michael Spencer wrote:
> Committed as r161067. Thanks!
>
> Can you create futures patches relative to the lld directory instead
> of llvm? I don't have lld checked out inside llvm.

Sorry, my mistake.  But thanks for committing it.

Cheers
Andy

 
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev