combined arm patch

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

combined arm patch

Rafael Espíndola
Attached is the current ARM patch. It allows the LLVM branch to
compile on linux/arm and the resulting libgcc is compatible with a
glibc compiled a vanilla gcc,i.e, a statically compiled hello world
works :-)

The patch was constructed by merging patches from gcc 4.1 with minimal
editing for making merging easier. It was requested that I bracket the
changes, I will try to remove all unnecessary parts, like C++ support.
Is this ok or should I bracket the complete patch? Note that some
changes are just updates to auto generated files...

Best Regards,
Rafael

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

arm.patch.bz2 (50K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: combined arm patch

Jim Laskey
Rafael,

Please bracket portions of your changes that involve modification of  
C/C++ source code.  For cases of modifying configuration scripts and  
make files, use your best judgement.  Obviously having the brackets  
emitted in generated code is problematic (line numbers et cetera), so  
don't bother in those cases.

Beside marking the changes we've made, the purpose of APPLE LOCAL  
brackets is reduce confusion when we merge with the main branch  
(sometimes a very hairy task when there are lots of conflicts.)

Cheers,

-- Jim



On Dec 1, 2006, at 4:30 PM, Rafael Espíndola wrote:

> Attached is the current ARM patch. It allows the LLVM branch to
> compile on linux/arm and the resulting libgcc is compatible with a
> glibc compiled a vanilla gcc,i.e, a statically compiled hello world
> works :-)
>
> The patch was constructed by merging patches from gcc 4.1 with minimal
> editing for making merging easier. It was requested that I bracket the
> changes, I will try to remove all unnecessary parts, like C++ support.
> Is this ok or should I bracket the complete patch? Note that some
> changes are just updates to auto generated files...
>
> Best Regards,
> Rafael
> <arm.patch.bz2>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: combined arm patch

Rafael Espíndola
On 12/2/06, Jim Laskey <[hidden email]> wrote:

> Rafael,
>
> Please bracket portions of your changes that involve modification of
> C/C++ source code.  For cases of modifying configuration scripts and
> make files, use your best judgement.  Obviously having the brackets
> emitted in generated code is problematic (line numbers et cetera), so
> don't bother in those cases.
>
> Beside marking the changes we've made, the purpose of APPLE LOCAL
> brackets is reduce confusion when we merge with the main branch
> (sometimes a very hairy task when there are lots of conflicts.)
I think that adding the marks may actually increase the number of
spurious conflicts (I had some problem with them while backporting
patches from 4.1).

Anyway, I have attached a version with the brackets. Is it ok? I
believe that it is mostly ARM specific. A bootstrap on a AMD64 breaks
on the same spot as before :-)

> Cheers,

Best Regards,
Rafael

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

arm.patch.bz2 (49K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: combined arm patch

Jim Laskey
Greatly  appreciated, I attempt to make tomorrows mirror.

Cheers,

-- Jim


On Dec 4, 2006, at 4:32 PM, Rafael Espíndola wrote:

> On 12/2/06, Jim Laskey <[hidden email]> wrote:
>> Rafael,
>>
>> Please bracket portions of your changes that involve modification of
>> C/C++ source code.  For cases of modifying configuration scripts and
>> make files, use your best judgement.  Obviously having the brackets
>> emitted in generated code is problematic (line numbers et cetera), so
>> don't bother in those cases.
>>
>> Beside marking the changes we've made, the purpose of APPLE LOCAL
>> brackets is reduce confusion when we merge with the main branch
>> (sometimes a very hairy task when there are lots of conflicts.)
>
> I think that adding the marks may actually increase the number of
> spurious conflicts (I had some problem with them while backporting
> patches from 4.1).
>
> Anyway, I have attached a version with the brackets. Is it ok? I
> believe that it is mostly ARM specific. A bootstrap on a AMD64 breaks
> on the same spot as before :-)
>
>> Cheers,
>
> Best Regards,
> Rafael
> <arm.patch.bz2>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: combined arm patch

Jim Laskey
Try again.  I'll  attempt to make tomorrows mirror.
On Dec 4, 2006, at 9:05 PM, Jim Laskey wrote:

> Greatly  appreciated, I attempt to make tomorrows mirror.
>
> Cheers,
>
> -- Jim  
>
> On Dec 4, 2006, at 4:32 PM, Rafael Espíndola wrote:
>
>> On 12/2/06, Jim Laskey <[hidden email]> wrote:
>>> Rafael,
>>>
>>> Please bracket portions of your changes that involve modification of
>>> C/C++ source code.  For cases of modifying configuration scripts and
>>> make files, use your best judgement.  Obviously having the brackets
>>> emitted in generated code is problematic (line numbers et  
>>> cetera), so
>>> don't bother in those cases.
>>>
>>> Beside marking the changes we've made, the purpose of APPLE LOCAL
>>> brackets is reduce confusion when we merge with the main branch
>>> (sometimes a very hairy task when there are lots of conflicts.)
>>
>> I think that adding the marks may actually increase the number of
>> spurious conflicts (I had some problem with them while backporting
>> patches from 4.1).
>>
>> Anyway, I have attached a version with the brackets. Is it ok? I
>> believe that it is mostly ARM specific. A bootstrap on a AMD64 breaks
>> on the same spot as before :-)
>>
>>> Cheers,
>>
>> Best Regards,
>> Rafael
>> <arm.patch.bz2>
>> _______________________________________________
>> LLVM Developers mailing list
>> [hidden email]         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: combined arm patch

Jim Laskey
In reply to this post by Rafael Espíndola
This patch should be in today's mirror ~6am PST.

Cheers,

-- Jim

On Dec 4, 2006, at 4:32 PM, Rafael Espíndola wrote:

> On 12/2/06, Jim Laskey <[hidden email]> wrote:
>> Rafael,
>>
>> Please bracket portions of your changes that involve modification of
>> C/C++ source code.  For cases of modifying configuration scripts and
>> make files, use your best judgement.  Obviously having the brackets
>> emitted in generated code is problematic (line numbers et cetera), so
>> don't bother in those cases.
>>
>> Beside marking the changes we've made, the purpose of APPLE LOCAL
>> brackets is reduce confusion when we merge with the main branch
>> (sometimes a very hairy task when there are lots of conflicts.)
>
> I think that adding the marks may actually increase the number of
> spurious conflicts (I had some problem with them while backporting
> patches from 4.1).
>
> Anyway, I have attached a version with the brackets. Is it ok? I
> believe that it is mostly ARM specific. A bootstrap on a AMD64 breaks
> on the same spot as before :-)
>
>> Cheers,
>
> Best Regards,
> Rafael
>

> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

arm.patch.bz2 (49K) Download Attachment
smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-commits] combined arm patch

Jim Laskey
I had to revert these changes.  When I did a clean build I was  
inundated with errors.  I'm not sure if I made the cut off time for  
the mirror.

-- Jim


On Dec 5, 2006, at 8:35 AM, Jim Laskey wrote:

> This patch should be in today's mirror ~6am PST.
>
> Cheers,
>
> -- Jim
>
> On Dec 4, 2006, at 4:32 PM, Rafael Espíndola wrote:
>
>> On 12/2/06, Jim Laskey <[hidden email]> wrote:
>>> Rafael,
>>>
>>> Please bracket portions of your changes that involve modification of
>>> C/C++ source code.  For cases of modifying configuration scripts and
>>> make files, use your best judgement.  Obviously having the brackets
>>> emitted in generated code is problematic (line numbers et  
>>> cetera), so
>>> don't bother in those cases.
>>>
>>> Beside marking the changes we've made, the purpose of APPLE LOCAL
>>> brackets is reduce confusion when we merge with the main branch
>>> (sometimes a very hairy task when there are lots of conflicts.)
>>
>> I think that adding the marks may actually increase the number of
>> spurious conflicts (I had some problem with them while backporting
>> patches from 4.1).
>>
>> Anyway, I have attached a version with the brackets. Is it ok? I
>> believe that it is mostly ARM specific. A bootstrap on a AMD64 breaks
>> on the same spot as before :-)
>>
>>> Cheers,
>>
>> Best Regards,
>> Rafael
>>
>
> <arm.patch.bz2>
>> _______________________________________________
>> LLVM Developers mailing list
>> [hidden email]         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
> _______________________________________________
> llvm-commits mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-commits] combined arm patch

Rafael Espíndola
On 12/5/06, Jim Laskey <[hidden email]> wrote:
> I had to revert these changes.  When I did a clean build I was
> inundated with errors.  I'm not sure if I made the cut off time for
> the mirror.
Could you please send me the log? The bootstrap is broken on linux
amd64 for some time now, so it is hard for me to do a full test :-(

> -- Jim

Sorry for the problems,
Rafael
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-commits] combined arm patch

Jim Laskey
Log sent to Rafael offline.

On Dec 5, 2006, at 9:56 AM, Rafael Espíndola wrote:

> On 12/5/06, Jim Laskey <[hidden email]> wrote:
>> I had to revert these changes.  When I did a clean build I was
>> inundated with errors.  I'm not sure if I made the cut off time for
>> the mirror.
> Could you please send me the log? The bootstrap is broken on linux
> amd64 for some time now, so it is hard for me to do a full test :-(
>
>> -- Jim
>
> Sorry for the problems,
> Rafael

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-commits] combined arm patch

Rafael Espíndola
In reply to this post by Jim Laskey
On 12/5/06, Jim Laskey <[hidden email]> wrote:
> I had to revert these changes.  When I did a clean build I was
> inundated with errors.  I'm not sure if I made the cut off time for
> the mirror.

Apparently the problem is caused by the patch making gcc/unwind.h
empty but not removing it !!!!

Could you please try to remove the empty gcc/unwind.h and try again? I
am currently compiling on a powerbook. I will report as soon as it
finishes.

Best Regards,
Rafael
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-commits] combined arm patch

Rafael Espíndola
> Could you please try to remove the empty gcc/unwind.h and try again? I
> am currently compiling on a powerbook. I will report as soon as it
> finishes.

The build finished successfully!

Rafael
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [llvm-commits] combined arm patch

Lauro Ramos Venancio
The following patch updates Rafael's patch to apply it on svn revision 247.

Lauro

2006/12/6, Rafael Espíndola <[hidden email]>:
> Could you please try to remove the empty gcc/unwind.h and try again? I
> am currently compiling on a powerbook. I will report as soon as it
> finishes.

The build finished successfully!

Rafael
_______________________________________________
llvm-commits mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

arm.patch.bz2 (44K) Download Attachment