a quick typo in the ARM LLVM backend

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

a quick typo in the ARM LLVM backend

Jay Freeman (saurik)
So, a while back I got a compile error where the assembly was missing some whitespace between a .set and the identifier and tracked it down to this simple mistake that I just verified is still in the tree:
 
Index: lib/Target/ARM/ARMTargetAsmInfo.cpp
===================================================================
--- lib/Target/ARM/ARMTargetAsmInfo.cpp (revision 48700)
+++ lib/Target/ARM/ARMTargetAsmInfo.cpp (working copy)
@@ -49,7 +49,7 @@
     PrivateGlobalPrefix = "L";
     BSSSection = 0;                       // no BSS section.
     ZeroFillDirective = "\t.zerofill\t";  // Uses .zerofill
-    SetDirective = "\t.set";
+    SetDirective = "\t.set\t";
     WeakRefDirective = "\t.weak_reference\t";
     HiddenDirective = "\t.private_extern\t";
     ProtectedDirective = NULL;
I unfortunately don't have the code that died anymore (it was a couple months ago, and I'm unfortunately just now getting on this mailing list to report the issue), but it seems pretty obvious from the surrounding context to be wrong, and there's even another initialization of SetDirective in the same file that _does_ have the traililng \t.
 
Sincerely,
Jay Freeman (saurik)

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: a quick typo in the ARM LLVM backend

Evan Cheng-2
Committed. Thanks!

Evan

On Mar 23, 2008, at 4:39 AM, Jay Freeman (saurik) wrote:
So, a while back I got a compile error where the assembly was missing some whitespace between a .set and the identifier and tracked it down to this simple mistake that I just verified is still in the tree:
 
Index: lib/Target/ARM/ARMTargetAsmInfo.cpp
===================================================================
--- lib/Target/ARM/ARMTargetAsmInfo.cpp (revision 48700)
+++ lib/Target/ARM/ARMTargetAsmInfo.cpp (working copy)
@@ -49,7 +49,7 @@
     PrivateGlobalPrefix = "L";
     BSSSection = 0;                       // no BSS section.
     ZeroFillDirective = "\t.zerofill\t";  // Uses .zerofill
-    SetDirective = "\t.set";
+    SetDirective = "\t.set\t";
     WeakRefDirective = "\t.weak_reference\t";
     HiddenDirective = "\t.private_extern\t";
     ProtectedDirective = NULL;
I unfortunately don't have the code that died anymore (it was a couple months ago, and I'm unfortunately just now getting on this mailing list to report the issue), but it seems pretty obvious from the surrounding context to be wrong, and there's even another initialization of SetDirective in the same file that _does_ have the traililng \t.
 
Sincerely,
Jay Freeman (saurik)
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev