What is AMDGPUSubtarget::getDefaultSize for?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

What is AMDGPUSubtarget::getDefaultSize for?

Craig Topper
It's marked virtual but doesn't override anything, has no overrides, and no in tree callers. Can it be removed?

--
~Craig

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: What is AMDGPUSubtarget::getDefaultSize for?

Rafael Espíndola
On 30 April 2014 00:53, Craig Topper <[hidden email]> wrote:
> It's marked virtual but doesn't override anything, has no overrides, and no
> in tree callers. Can it be removed?

In general, it is always OK to delete dead code. If it had an intended
use, it is easy to bring it back from svn and properly enable and test
it.

Cheers,
Rafale
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: What is AMDGPUSubtarget::getDefaultSize for?

Tom Stellard-3
In reply to this post by Craig Topper
On Tue, Apr 29, 2014 at 09:53:18PM -0700, Craig Topper wrote:
> It's marked virtual but doesn't override anything, has no overrides, and no
> in tree callers. Can it be removed?
>

I removed this function in r207654.

-Tom

> --
> ~Craig

> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev