VS build is broken again

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

VS build is broken again

Dmitri Makarov
attached is the diff of vcprojs that need to be changed to fix the VS
build as of revision:  51224.

I don't know if this catches all the missing bits, but this does build
all the way through.


     
Index: win32/Analysis/Analysis.vcproj
===================================================================
--- win32/Analysis/Analysis.vcproj      (revision 51223)
+++ win32/Analysis/Analysis.vcproj      (working copy)
@@ -353,6 +353,14 @@
                                >
                        </File>
                        <File
+                               RelativePath="..\..\lib\Analysis\LibCallAliasAnalysis.cpp"
+                               >
+                       </File>
+                       <File
+                               RelativePath="..\..\lib\Analysis\LibCallSemantics.cpp"
+                               >
+                       </File>
+                       <File
                                RelativePath="..\..\lib\Analysis\LoadValueNumbering.cpp"
                                >
                        </File>
Index: win32/Transforms/Transforms.vcproj
===================================================================
--- win32/Transforms/Transforms.vcproj  (revision 51223)
+++ win32/Transforms/Transforms.vcproj  (working copy)
@@ -396,10 +396,6 @@
                                        >
                                </File>
                                <File
-                                       RelativePath="..\..\lib\Transforms\Ipo\SimplifyLibCalls.cpp"
-                                       >
-                               </File>
-                               <File
                                        RelativePath="..\..\lib\Transforms\IPO\StripDeadPrototypes.cpp"
                                        >
                                </File>
@@ -524,7 +520,7 @@
                                        >
                                </File>
                                <File
-                                       RelativePath="..\..\lib\Transforms\Scalar\SimplifyCFG.cpp"
+                                       RelativePath="..\..\lib\Transforms\Scalar\SimplifyCFGPass.cpp"
                                        >
                                </File>
                                <File

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Ted Kremenek-2
Hi Dmitri,

For what version of VS did you update the project files?

Ted

On May 17, 2008, at 3:00 PM, Dmitri Makarov wrote:

> attached is the diff of vcprojs that need to be changed to fix the VS
> build as of revision:  51224.
>
> I don't know if this catches all the missing bits, but this does build
> all the way through.
>
>
> Index: win32/Analysis/Analysis.vcproj
> ===================================================================
> --- win32/Analysis/Analysis.vcproj      (revision 51223)
> +++ win32/Analysis/Analysis.vcproj      (working copy)
> @@ -353,6 +353,14 @@
>>
>                        </File>
>                        <File
> +                               RelativePath="..\..\lib\Analysis
> \LibCallAliasAnalysis.cpp"
> +                               >
> +                       </File>
> +                       <File
> +                               RelativePath="..\..\lib\Analysis
> \LibCallSemantics.cpp"
> +                               >
> +                       </File>
> +                       <File
>                                RelativePath="..\..\lib\Analysis
> \LoadValueNumbering.cpp"
>>
>                        </File>
> Index: win32/Transforms/Transforms.vcproj
> ===================================================================
> --- win32/Transforms/Transforms.vcproj  (revision 51223)
> +++ win32/Transforms/Transforms.vcproj  (working copy)
> @@ -396,10 +396,6 @@
>>
>                                </File>
>                                <File
> -                                       RelativePath="..\..\lib
> \Transforms\Ipo\SimplifyLibCalls.cpp"
> -                                       >
> -                               </File>
> -                               <File
>                                        RelativePath="..\..\lib
> \Transforms\IPO\StripDeadPrototypes.cpp"
>>
>                                </File>
> @@ -524,7 +520,7 @@
>>
>                                </File>
>                                <File
> -                                       RelativePath="..\..\lib
> \Transforms\Scalar\SimplifyCFG.cpp"
> +                                       RelativePath="..\..\lib
> \Transforms\Scalar\SimplifyCFGPass.cpp"
>>
>                                </File>
>                                <File
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Ted Kremenek-2
Please disregard.  I didn't see the later messages in this thread.

On May 17, 2008, at 9:49 PM, Ted Kremenek wrote:

> Hi Dmitri,
>
> For what version of VS did you update the project files?
>
> Ted
>
> On May 17, 2008, at 3:00 PM, Dmitri Makarov wrote:
>
>> attached is the diff of vcprojs that need to be changed to fix the VS
>> build as of revision:  51224.
>>
>> I don't know if this catches all the missing bits, but this does  
>> build
>> all the way through.
>>
>>
>> Index: win32/Analysis/Analysis.vcproj
>> ===================================================================
>> --- win32/Analysis/Analysis.vcproj      (revision 51223)
>> +++ win32/Analysis/Analysis.vcproj      (working copy)
>> @@ -353,6 +353,14 @@
>>>
>>                       </File>
>>                       <File
>> +                               RelativePath="..\..\lib\Analysis
>> \LibCallAliasAnalysis.cpp"
>> +                               >
>> +                       </File>
>> +                       <File
>> +                               RelativePath="..\..\lib\Analysis
>> \LibCallSemantics.cpp"
>> +                               >
>> +                       </File>
>> +                       <File
>>                               RelativePath="..\..\lib\Analysis
>> \LoadValueNumbering.cpp"
>>>
>>                       </File>
>> Index: win32/Transforms/Transforms.vcproj
>> ===================================================================
>> --- win32/Transforms/Transforms.vcproj  (revision 51223)
>> +++ win32/Transforms/Transforms.vcproj  (working copy)
>> @@ -396,10 +396,6 @@
>>>
>>                               </File>
>>                               <File
>> -                                       RelativePath="..\..\lib
>> \Transforms\Ipo\SimplifyLibCalls.cpp"
>> -                                       >
>> -                               </File>
>> -                               <File
>>                                       RelativePath="..\..\lib
>> \Transforms\IPO\StripDeadPrototypes.cpp"
>>>
>>                               </File>
>> @@ -524,7 +520,7 @@
>>>
>>                               </File>
>>                               <File
>> -                                       RelativePath="..\..\lib
>> \Transforms\Scalar\SimplifyCFG.cpp"
>> +                                       RelativePath="..\..\lib
>> \Transforms\Scalar\SimplifyCFGPass.cpp"
>>>
>>                               </File>
>>                               <File
>> _______________________________________________
>> LLVM Developers mailing list
>> [hidden email]         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Dmitri Makarov
In reply to this post by Ted Kremenek-2
VS 2005

--- Ted Kremenek <[hidden email]> wrote:

> Hi Dmitri,
>
> For what version of VS did you update the project files?
>
> Ted
>
> On May 17, 2008, at 3:00 PM, Dmitri Makarov wrote:
>
> > attached is the diff of vcprojs that need to be changed to fix the
> VS
> > build as of revision:  51224.
> >
> > I don't know if this catches all the missing bits, but this does
> build
> > all the way through.
> >
> >
> > Index: win32/Analysis/Analysis.vcproj
> > ===================================================================
> > --- win32/Analysis/Analysis.vcproj      (revision 51223)
> > +++ win32/Analysis/Analysis.vcproj      (working copy)
> > @@ -353,6 +353,14 @@
> >>
> >                        </File>
> >                        <File
> > +                               RelativePath="..\..\lib\Analysis
> > \LibCallAliasAnalysis.cpp"
> > +                               >
> > +                       </File>
> > +                       <File
> > +                               RelativePath="..\..\lib\Analysis
> > \LibCallSemantics.cpp"
> > +                               >
> > +                       </File>
> > +                       <File
> >                                RelativePath="..\..\lib\Analysis
> > \LoadValueNumbering.cpp"
> >>
> >                        </File>
> > Index: win32/Transforms/Transforms.vcproj
> > ===================================================================
> > --- win32/Transforms/Transforms.vcproj  (revision 51223)
> > +++ win32/Transforms/Transforms.vcproj  (working copy)
> > @@ -396,10 +396,6 @@
> >>
> >                                </File>
> >                                <File
> > -                                       RelativePath="..\..\lib
> > \Transforms\Ipo\SimplifyLibCalls.cpp"
> > -                                       >
> > -                               </File>
> > -                               <File
> >                                        RelativePath="..\..\lib
> > \Transforms\IPO\StripDeadPrototypes.cpp"
> >>
> >                                </File>
> > @@ -524,7 +520,7 @@
> >>
> >                                </File>
> >                                <File
> > -                                       RelativePath="..\..\lib
> > \Transforms\Scalar\SimplifyCFG.cpp"
> > +                                       RelativePath="..\..\lib
> > \Transforms\Scalar\SimplifyCFGPass.cpp"
> >>
> >                                </File>
> >                                <File
> > _______________________________________________
> > LLVM Developers mailing list
> > [hidden email]         http://llvm.cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>



     
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Dmitri Makarov
In reply to this post by Dmitri Makarov
Ted,

Thanks for taking care of this.  I found that in order to build clang
(in addition to the vcproj changes I posted earlier today) I had to add
a dependency such that the clangDriver project depends on the CodeGen
(basically the CodeGen checkbox has to be checked in the list of the
clangDriver's dependencies).  This in effect adds codegen.lib to the
list of libraries linked into clang.exe and solves all the unresolved
symbol errors in the clang build.  I would submit the diff, but it
looks like visual studio changes all the encodings of projects in the
.sln file, so the diff includes a lot of irrelevant lines.

Thanks
Dmitri

--- Ted Kremenek <[hidden email]> wrote:

>
> On May 17, 2008, at 10:04 PM, Dmitri Makarov wrote:
>
> > If I'm not mistaken about a week ago llvm.sln used to be VS 2008
> > version and now it's VS 2005 again.  I don't follow the llvm lists
> too
> > close to know what happened. So, really, what's going on with the
> VS
> > build?  Clang.sln has always been VS 2005. All this is frustrating.
>
>
> I find it frustrating as well.  Here is my understanding of the  
> situation.
>
> One of the clang contributors upgraded the project file to VS 2008.  
>
> Another clang contributor (who is also an Apple employee) is using VS
>  
> 2005 (but not VS 2008) to build clang on Windows, and decided to  
> revert the patch upgrading the VS project files to 2008.  However, I
>
> imagine the project files were upgraded for a reason, i.e., the build
>  
> was broken, but the person who reverted the patch I believe did not
> go  
> ahead and upgrade the project files on VS 2005.  This is at least my
>
> interpretation of the situation.  I'm trying to find out what the  
> exact status of the build (both LLVM and clang) is on VS 2005, and
> get  
> the situation straightened out.
>
> The main problem is that there is no regular maintainer of the LLVM/
> clang build on VS, and we want to keep the project files using VS  
> 2005, not VS 2008.
>



     
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Ted Kremenek-2

On May 17, 2008, at 11:51 PM, Dmitri Makarov wrote:

> This in effect adds codegen.lib to the
> list of libraries linked into clang.exe and solves all the unresolved
> symbol errors in the clang build.  I would submit the diff, but it
> looks like visual studio changes all the encodings of projects in the
> .sln file, so the diff includes a lot of irrelevant lines.

Changes all the encodings?  Does this have to do with locale settings?
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Dmitri Makarov
If you look at an .sln file, there's a long sequence of digits
associated with every project, something like this
8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942. For the lack of a better word I
called it "encoding".  After I changed the dependencies between
projects in the solution, msvs replaced those numeric sequences by new
ones literally for every project in the solution file. The diff now
includes all such changes of numeric sequences associated with each
project, which are not really relevant to the problem at all.  I don't
think it matters and would work for anyone equally well, but
nevertheless not to confuse you with such a large diff, I think it's
better if someone on your site would just add the dependency I
mentioned before and would check-in his .sln file.

--- Ted Kremenek <[hidden email]> wrote:

>
> On May 17, 2008, at 11:51 PM, Dmitri Makarov wrote:
>
> > This in effect adds codegen.lib to the
> > list of libraries linked into clang.exe and solves all the
> unresolved
> > symbol errors in the clang build.  I would submit the diff, but it
> > looks like visual studio changes all the encodings of projects in
> the
> > .sln file, so the diff includes a lot of irrelevant lines.
>
> Changes all the encodings?  Does this have to do with locale
> settings?
>



     
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Ted Kremenek-2
Hi Dmitri,

I know what you are saying, but in the end I think we are lucky if  
diffs against project files have any meaningful information.  Nobody  
right now assumes responsibility for regularly updating the VS files,  
so we routinely get patches from different people when they decide to  
upgrade the project files, and these patches change the .sln files in  
arbitrary ways.

If you have successfully modified the VC project files in both LLVM  
and clang to (1) build with TOT and (2) work with VS 2005 then please  
go ahead an email me the patches.  I will patch them immediately, and  
if anyone has any problems with the patch they can be reverted.  I  
think it is more important to get the build working again for everyone  
on Windows.

BTW, please email me the patches in a zip file.  For some reason,  
inlining of the patches within a email message can cause problems with  
Apple's Mail program (weird CRLF issues, etc.).

Thanks!

Ted

On May 18, 2008, at 1:07 PM, Dmitri Makarov wrote:

> If you look at an .sln file, there's a long sequence of digits
> associated with every project, something like this
> 8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942. For the lack of a better word I
> called it "encoding".  After I changed the dependencies between
> projects in the solution, msvs replaced those numeric sequences by new
> ones literally for every project in the solution file. The diff now
> includes all such changes of numeric sequences associated with each
> project, which are not really relevant to the problem at all.  I don't
> think it matters and would work for anyone equally well, but
> nevertheless not to confuse you with such a large diff, I think it's
> better if someone on your site would just add the dependency I
> mentioned before and would check-in his .sln file.
>
> --- Ted Kremenek <[hidden email]> wrote:
>
>>
>> On May 17, 2008, at 11:51 PM, Dmitri Makarov wrote:
>>
>>> This in effect adds codegen.lib to the
>>> list of libraries linked into clang.exe and solves all the
>> unresolved
>>> symbol errors in the clang build.  I would submit the diff, but it
>>> looks like visual studio changes all the encodings of projects in
>> the
>>> .sln file, so the diff includes a lot of irrelevant lines.
>>
>> Changes all the encodings?  Does this have to do with locale
>> settings?
>>
>
>
>
>

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Dmitri Makarov
Ted,

Attached is the diff against TOT.  It makes the VS build work for me.
Solution/project files work with VS 2005.  Project files in clang need
not to be modified.  As it happens, the solution file for clang is part
of the llvm tree ( go figure... )

Thanks
Dmitri

--- Ted Kremenek <[hidden email]> wrote:

> Hi Dmitri,
>
> I know what you are saying, but in the end I think we are lucky if  
> diffs against project files have any meaningful information.  Nobody
>
> right now assumes responsibility for regularly updating the VS files,
>  
> so we routinely get patches from different people when they decide to
>  
> upgrade the project files, and these patches change the .sln files in
>  
> arbitrary ways.
>
> If you have successfully modified the VC project files in both LLVM  
> and clang to (1) build with TOT and (2) work with VS 2005 then please
>  
> go ahead an email me the patches.  I will patch them immediately, and
>  
> if anyone has any problems with the patch they can be reverted.  I  
> think it is more important to get the build working again for
> everyone  
> on Windows.
>
> BTW, please email me the patches in a zip file.  For some reason,  
> inlining of the patches within a email message can cause problems
> with  
> Apple's Mail program (weird CRLF issues, etc.).
>
> Thanks!
>
> Ted
>
> On May 18, 2008, at 1:07 PM, Dmitri Makarov wrote:
>
> > If you look at an .sln file, there's a long sequence of digits
> > associated with every project, something like this
> > 8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942. For the lack of a better word
> I
> > called it "encoding".  After I changed the dependencies between
> > projects in the solution, msvs replaced those numeric sequences by
> new
> > ones literally for every project in the solution file. The diff now
> > includes all such changes of numeric sequences associated with each
> > project, which are not really relevant to the problem at all.  I
> don't
> > think it matters and would work for anyone equally well, but
> > nevertheless not to confuse you with such a large diff, I think
> it's
> > better if someone on your site would just add the dependency I
> > mentioned before and would check-in his .sln file.
> >
> > --- Ted Kremenek <[hidden email]> wrote:
> >
> >>
> >> On May 17, 2008, at 11:51 PM, Dmitri Makarov wrote:
> >>
> >>> This in effect adds codegen.lib to the
> >>> list of libraries linked into clang.exe and solves all the
> >> unresolved
> >>> symbol errors in the clang build.  I would submit the diff, but
> it
> >>> looks like visual studio changes all the encodings of projects in
> >> the
> >>> .sln file, so the diff includes a lot of irrelevant lines.
> >>
> >> Changes all the encodings?  Does this have to do with locale
> >> settings?
> >>
> >
> >
> >
> >
>
>


     
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

msvspatch.zip (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Ted Kremenek-2
Wonderful.  Applied!

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080512/062599.html

VS users: Please verify that this patch works for you.

Thanks so much Dmitri!

On May 18, 2008, at 7:42 PM, Dmitri Makarov wrote:

> Ted,
>
> Attached is the diff against TOT.  It makes the VS build work for me.
> Solution/project files work with VS 2005.  Project files in clang need
> not to be modified.  As it happens, the solution file for clang is  
> part
> of the llvm tree ( go figure... )
>
> Thanks
> Dmitri
>

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: VS build is broken again

Gordon Henriksen-3
In reply to this post by Dmitri Makarov
These are UUIDs, also known as GUIDs.

http://en.wikipedia.org/wiki/UUID

On 2008-05-18, at 16:07, Dmitri Makarov wrote:

> If you look at an .sln file, there's a long sequence of digits
> associated with every project, something like this
> 8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942. For the lack of a better word I
> called it "encoding".  After I changed the dependencies between
> projects in the solution, msvs replaced those numeric sequences by new
> ones literally for every project in the solution file. The diff now
> includes all such changes of numeric sequences associated with each
> project, which are not really relevant to the problem at all.  I don't
> think it matters and would work for anyone equally well, but
> nevertheless not to confuse you with such a large diff, I think it's
> better if someone on your site would just add the dependency I
> mentioned before and would check-in his .sln file.
>
> --- Ted Kremenek <[hidden email]> wrote:
>
>>
>> On May 17, 2008, at 11:51 PM, Dmitri Makarov wrote:
>>
>>> This in effect adds codegen.lib to the
>>> list of libraries linked into clang.exe and solves all the
>> unresolved
>>> symbol errors in the clang build.  I would submit the diff, but it
>>> looks like visual studio changes all the encodings of projects in
>> the
>>> .sln file, so the diff includes a lot of irrelevant lines.
>>
>> Changes all the encodings?  Does this have to do with locale
>> settings?
>>
>
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev



— Gordon


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev