RFC: tailcall ppc32 patch

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFC: tailcall ppc32 patch

Arnold Schwaighofer
Hi there,

it's me again. attached is preliminary support for tail calls on ppc
32. (once i get access to a 64bit machine that part will follow). It
has passed the llvm-test with the -tailcallopt flag enabled. (after
half a day on an old g4/800 :)

okay to submit? probably not. :) suggestions.

regards
arnold

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

tc-ppc.patch (76K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: RFC: tailcall ppc32 patch

Evan Cheng-2

On Mar 26, 2008, at 11:29 PM, Arnold Schwaighofer wrote:

> Hi there,
>
> it's me again. attached is preliminary support for tail calls on ppc
> 32. (once i get access to a 64bit machine that part will follow). It
> has passed the llvm-test with the -tailcallopt flag enabled. (after
> half a day on an old g4/800 :)
>
> okay to submit? probably not. :) suggestions.

I can see some stylistic issues. e.g. getFramePointerFrameIndex() etc.  
should be declared const, also please make sure there is a space  
between 'if' and '('. But I don't enough about PPC to really pick on  
it. :-)

Dale, can you look through the patch?

Thanks,

Evan

>
>
> regards
> arnold
> <tc-ppc.patch>_______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev