RFC: put commit messages in *-commits subject lines?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
41 messages Options
123
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Daniel Dunbar
Hi Sebastion,

I've attached the current configuration file from the server.

I'm not sure how far you want to go down the "trying to get realize nice summary path" lines, but if svn_mailer somehow supported running an external script to process the commit and come up with the path that would be ideal for integration on the server.

 - Daniel


On Fri, Jan 25, 2013 at 12:59 PM, Sebastian Pop <[hidden email]> wrote:
Jordan Rose wrote:
> +John C and Daniel, who have access to the servers.
>
> Way back when this thread was first active I asked around off-list where this needs to happen, and Daniel and Tanya said this (respectively):
>
> >> I'd prefer to stick with using either svn-mailer or svnnotify, as those are the ones we use in other places. svnnotify in particular is very full featured, although we would need to install it on the server but that is straightforward.
> >>
> > Maybe. The server is very out of date, and there are no packages anymore for it.. so if its just one file then that might work ;)
> >
> > I need to get John C. to update the OS again. He didn't do it and then Zac came early.. so it never got done. But its time and needs to be done. Once thats done, it will allow us to upgrade llvm.org much easier.
>
> Sebastian, maybe you can psas your full config file on to John and Daniel?

I started looking at this problem in a blind way:

> I see that currently the commit emails contain this marker in the header:
> X-Mailer: svnmailer-1.0.9
> So the following fixes assume that we are running svnmailer-1.0.9.

If somebody can send me the current config file from the server, I will modify
that, test locally, and send back a patch.  If you decide to switch to svnnotify,
you wouldn't need my fixes, but I would still be happy to help if needed.

Let's get this bug fixed ;-)

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

svn-mailer.conf (29K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Sebastian Pop-7
Hi Daniel,

Daniel Dunbar wrote:
> Hi Sebastion,
>
> I've attached the current configuration file from the server.
>
> I'm not sure how far you want to go down the "trying to get realize nice
> summary path" lines, but if svn_mailer somehow supported running an
> external script to process the commit and come up with the path that would
> be ideal for integration on the server.

I think you could modify the sources of svn_mailer to add such a hook.  When I
first investigated this issue, I ended on a bug report from the debian project
that fixed the subject line with a one line patch:

> To get the first line of the log message as a subject line, please apply this
> one line patch: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=17;bug=379534
> Note that you can directly patch the installed script: on my machine it is
> located in /usr/local/lib/python2.7/dist-packages/svnmailer/notifier/_mail.py

For your convenience, here is the patch from that debian bug report:


svnmailer: add log substitution for subject templates

Add first line of commit log as a substitution variable for
*_subject_template, E.G. add %(log)s to use.

Signed-off-by: Peter Korsgaard <[hidden email]>

Index: svnmailer-1.0.8/src/lib/svnmailer/notifier/_mail.py
===================================================================
--- svnmailer-1.0.8.orig/src/lib/svnmailer/notifier/_mail.py 2008-05-27 14:56:27.000000000 +0200
+++ svnmailer-1.0.8/src/lib/svnmailer/notifier/_mail.py 2008-05-27 15:01:50.000000000 +0200
@@ -314,6 +314,7 @@
             'part'    : countprefix,
             'files'   : self._getPrefixedFiles(changeset),
             'dirs'    : self._getPrefixedDirectories(changeset),
+            'log'     : self.getLog().split('\n',1)[0],
         }
 
         # We may try twice, first with files/dirs = files



Sebastian
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Sebastian Pop-7
Sebastian Pop wrote:

> Hi Daniel,
>
> Daniel Dunbar wrote:
> > Hi Sebastion,
> >
> > I've attached the current configuration file from the server.
> >
> > I'm not sure how far you want to go down the "trying to get realize nice
> > summary path" lines, but if svn_mailer somehow supported running an
> > external script to process the commit and come up with the path that would
> > be ideal for integration on the server.
>
> I think you could modify the sources of svn_mailer to add such a hook.  When I
> first investigated this issue, I ended on a bug report from the debian project
> that fixed the subject line with a one line patch:
>
> > To get the first line of the log message as a subject line, please apply this
> > one line patch: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=17;bug=379534
> > Note that you can directly patch the installed script: on my machine it is
> > located in /usr/local/lib/python2.7/dist-packages/svnmailer/notifier/_mail.py
>
> For your convenience, here is the patch from that debian bug report:
>
>
> svnmailer: add log substitution for subject templates
>
> Add first line of commit log as a substitution variable for
> *_subject_template, E.G. add %(log)s to use.
>
> Signed-off-by: Peter Korsgaard <[hidden email]>
>
> Index: svnmailer-1.0.8/src/lib/svnmailer/notifier/_mail.py
> ===================================================================
> --- svnmailer-1.0.8.orig/src/lib/svnmailer/notifier/_mail.py 2008-05-27 14:56:27.000000000 +0200
> +++ svnmailer-1.0.8/src/lib/svnmailer/notifier/_mail.py 2008-05-27 15:01:50.000000000 +0200
> @@ -314,6 +314,7 @@
>              'part'    : countprefix,
>              'files'   : self._getPrefixedFiles(changeset),
>              'dirs'    : self._getPrefixedDirectories(changeset),
> +            'log'     : self.getLog().split('\n',1)[0],
>          }
>  
>          # We may try twice, first with files/dirs = files
>
>

Once you patched the installed version of this file, in
/usr/local/lib/python2.7/dist-packages/svnmailer/notifier/_mail.py
you have two more changes in the config file you sent me: (the first change to
print the context of diff is something that I was missing more than the subject)

--- svn-mailer.conf.orig        2013-01-25 15:39:23.000000000 -0600
+++ svn-mailer.conf     2013-01-25 15:42:02.000000000 -0600
@@ -1,6 +1,6 @@
 [general]
 sendmail_command = /usr/sbin/sendmail
-diff_command = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %(to)s
+diff_command = /usr/bin/diff -up -L %(label_from)s -L %(label_to)s %(from)s %(to)s
 generate_diffs = add copy modify propchange
 
 [authors]
@@ -360,6 +360,7 @@
 mail_type = single
 show_applied_charset = nondefault
 custom_header = SVN-Repository %(REPOS)s
+commit_subject_template = %(prefix)s r%(revision)s - %(log)s
 
 [branch]
 for_repos = .*/llvm-project$



Note that I have not addressed the path prefix suggestion from David:

>>> For what it's worth, (I think) Chris' suggestion of including the
>>> directories was about including them "smart"ly by removing conceptual
>>> duplicates (lib/foo + include/foo + test/foo) and generally giving a
>>> brief sense of what a change is touching. If the change you have adds
>>> the full (repo-relative) path all the directories without any smart
>>> deduplication then I suspect it's going to easily push the log
>>> description off most mail readers (especially mobile) & reduce the
>>> value of this change.
>>>
>>> I suspect we'll want to just stick with revision + log for now.
>>
>> That's fine.  Alternatively we can provide a list of all the dirs that we want
>> to see appearing and match them like this:
>>
>> for_paths = .*(?P<SelectDirs>(lib/Analysis|lib/Transforms/Vectorize|lib/Transforms/Scalar)).*
>>
>> commit_subject_template = %(prefix)s r%(revision)s - [%(SelectDirs)s] %(log)s
>
>Could we go one step further and map these paths to names (eg: map
>"lib/Analysis", "include/llvm/Analysis", "test/Analysis" -> "Analysis"
>and unique the results)? Also, I'd prefer to have the dirs after the
>log message I think, though perhaps if we get them short enough it'd
>work.
>
>This solution does seem like it could involve a bit of manual work to
>update the list of blessed dirs all the time. If we could express it
>generically (lib/*, test/*, include/llvm/*) it might be OK, but as it
>stands I'm still not sure it's worth the hassle.

This could be done as Daniel has suggested, running a separate script that
filters and classifies in a smarter way the commits following the paths they are
touching.

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Daniel Dunbar



On Fri, Jan 25, 2013 at 2:06 PM, Sebastian Pop <[hidden email]> wrote:
Sebastian Pop wrote:
> Hi Daniel,
>
> Daniel Dunbar wrote:
> > Hi Sebastion,
> >
> > I've attached the current configuration file from the server.
> >
> > I'm not sure how far you want to go down the "trying to get realize nice
> > summary path" lines, but if svn_mailer somehow supported running an
> > external script to process the commit and come up with the path that would
> > be ideal for integration on the server.
>
> I think you could modify the sources of svn_mailer to add such a hook.  When I
> first investigated this issue, I ended on a bug report from the debian project
> that fixed the subject line with a one line patch:
>
> > To get the first line of the log message as a subject line, please apply this
> > one line patch: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=17;bug=379534
> > Note that you can directly patch the installed script: on my machine it is
> > located in /usr/local/lib/python2.7/dist-packages/svnmailer/notifier/_mail.py
>
> For your convenience, here is the patch from that debian bug report:
>
>
> svnmailer: add log substitution for subject templates
>
> Add first line of commit log as a substitution variable for
> *_subject_template, E.G. add %(log)s to use.
>
> Signed-off-by: Peter Korsgaard <[hidden email]>
>
> Index: svnmailer-1.0.8/src/lib/svnmailer/notifier/_mail.py
> ===================================================================
> --- svnmailer-1.0.8.orig/src/lib/svnmailer/notifier/_mail.py  2008-05-27 14:56:27.000000000 +0200
> +++ svnmailer-1.0.8/src/lib/svnmailer/notifier/_mail.py       2008-05-27 15:01:50.000000000 +0200
> @@ -314,6 +314,7 @@
>              'part'    : countprefix,
>              'files'   : self._getPrefixedFiles(changeset),
>              'dirs'    : self._getPrefixedDirectories(changeset),
> +            'log'     : self.getLog().split('\n',1)[0],
>          }
>
>          # We may try twice, first with files/dirs = files
>
>

Once you patched the installed version of this file, in
/usr/local/lib/python2.7/dist-packages/svnmailer/notifier/_mail.py
you have two more changes in the config file you sent me: (the first change to
print the context of diff is something that I was missing more than the subject)

I'm a bit hesitant to just hack up the installed copy of svnmailer, are we sure this patch hasn't been dealt with in an upstream version?
 

--- svn-mailer.conf.orig        2013-01-25 15:39:23.000000000 -0600
+++ svn-mailer.conf     2013-01-25 15:42:02.000000000 -0600
@@ -1,6 +1,6 @@
 [general]
 sendmail_command = /usr/sbin/sendmail
-diff_command = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %(to)s
+diff_command = /usr/bin/diff -up -L %(label_from)s -L %(label_to)s %(from)s %(to)s
 generate_diffs = add copy modify propchange

I'll go ahead and make this change.

 - Daniel
 

 [authors]
@@ -360,6 +360,7 @@
 mail_type = single
 show_applied_charset = nondefault
 custom_header = SVN-Repository %(REPOS)s
+commit_subject_template = %(prefix)s r%(revision)s - %(log)s

 [branch]
 for_repos = .*/llvm-project$



Note that I have not addressed the path prefix suggestion from David:

>>> For what it's worth, (I think) Chris' suggestion of including the
>>> directories was about including them "smart"ly by removing conceptual
>>> duplicates (lib/foo + include/foo + test/foo) and generally giving a
>>> brief sense of what a change is touching. If the change you have adds
>>> the full (repo-relative) path all the directories without any smart
>>> deduplication then I suspect it's going to easily push the log
>>> description off most mail readers (especially mobile) & reduce the
>>> value of this change.
>>>
>>> I suspect we'll want to just stick with revision + log for now.
>>
>> That's fine.  Alternatively we can provide a list of all the dirs that we want
>> to see appearing and match them like this:
>>
>> for_paths = .*(?P<SelectDirs>(lib/Analysis|lib/Transforms/Vectorize|lib/Transforms/Scalar)).*
>>
>> commit_subject_template = %(prefix)s r%(revision)s - [%(SelectDirs)s] %(log)s
>
>Could we go one step further and map these paths to names (eg: map
>"lib/Analysis", "include/llvm/Analysis", "test/Analysis" -> "Analysis"
>and unique the results)? Also, I'd prefer to have the dirs after the
>log message I think, though perhaps if we get them short enough it'd
>work.
>
>This solution does seem like it could involve a bit of manual work to
>update the list of blessed dirs all the time. If we could express it
>generically (lib/*, test/*, include/llvm/*) it might be OK, but as it
>stands I'm still not sure it's worth the hassle.

This could be done as Daniel has suggested, running a separate script that
filters and classifies in a smarter way the commits following the paths they are
touching.

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Sebastian Pop-7
Daniel Dunbar wrote:
> I'm a bit hesitant to just hack up the installed copy of svnmailer, are we
> sure this patch hasn't been dealt with in an upstream version?

I don't see that change in the last dev version:
http://storage.perlig.de/svnmailer/svnmailer-1.1.0-dev-r1373.tar.bz2

> > -diff_command = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s
> > %(from)s %(to)s
> > +diff_command = /usr/bin/diff -up -L %(label_from)s -L %(label_to)s
> > %(from)s %(to)s
> >  generate_diffs = add copy modify propchange
> >
>
> I'll go ahead and make this change.

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Daniel Dunbar
Yup, I didn't either. I went ahead and hacked up a copy with that change and am switching it over now.

 - Daniel


On Fri, Jan 25, 2013 at 3:06 PM, Sebastian Pop <[hidden email]> wrote:
Daniel Dunbar wrote:
> I'm a bit hesitant to just hack up the installed copy of svnmailer, are we
> sure this patch hasn't been dealt with in an upstream version?

I don't see that change in the last dev version:
http://storage.perlig.de/svnmailer/svnmailer-1.1.0-dev-r1373.tar.bz2

> > -diff_command = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s
> > %(from)s %(to)s
> > +diff_command = /usr/bin/diff -up -L %(label_from)s -L %(label_to)s
> > %(from)s %(to)s
> >  generate_diffs = add copy modify propchange
> >
>
> I'll go ahead and make this change.

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Daniel Dunbar
Ok, this is done and seems to work.

As far as Chris's request for getting "key directory" paths into the commit message, I thought about working on it, but in the end I'm not sure why we shouldn't just encourage people to self-tag their leading commit line with some sort of standard key ([MC], [Target/Mips], whatever).

 - Daniel


On Fri, Jan 25, 2013 at 3:11 PM, Daniel Dunbar <[hidden email]> wrote:
Yup, I didn't either. I went ahead and hacked up a copy with that change and am switching it over now.

 - Daniel


On Fri, Jan 25, 2013 at 3:06 PM, Sebastian Pop <[hidden email]> wrote:
Daniel Dunbar wrote:
> I'm a bit hesitant to just hack up the installed copy of svnmailer, are we
> sure this patch hasn't been dealt with in an upstream version?

I don't see that change in the last dev version:
http://storage.perlig.de/svnmailer/svnmailer-1.1.0-dev-r1373.tar.bz2

> > -diff_command = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s
> > %(from)s %(to)s
> > +diff_command = /usr/bin/diff -up -L %(label_from)s -L %(label_to)s
> > %(from)s %(to)s
> >  generate_diffs = add copy modify propchange
> >
>
> I'll go ahead and make this change.

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation



_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

NAKAMURA Takumi
2013/1/26 Daniel Dunbar <[hidden email]>:
> Ok, this is done and seems to work.

Cool!

> As far as Chris's request for getting "key directory" paths into the commit
> message, I thought about working on it, but in the end I'm not sure why we
> shouldn't just encourage people to self-tag their leading commit line with
> some sort of standard key ([MC], [Target/Mips], whatever).

+1. At least for now, I think it might be redundant to add "key directories".
We may watch on how better this change would have been.

...Takumi
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Tobias Grosser-5
In reply to this post by Daniel Dunbar
On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
> Ok, this is done and seems to work.
>
> As far as Chris's request for getting "key directory" paths into the
> commit message, I thought about working on it, but in the end I'm not
> sure why we shouldn't just encourage people to self-tag their leading
> commit line with some sort of standard key ([MC], [Target/Mips], whatever).

Very nice.

While at that, who can get rid of the [llvm],[cfe-commits], ...
prefixes? I remember we agreed they just cost screen real estate.

Tobi

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Daniel Dunbar



On Fri, Jan 25, 2013 at 4:00 PM, Tobias Grosser <[hidden email]> wrote:
On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
Ok, this is done and seems to work.

As far as Chris's request for getting "key directory" paths into the
commit message, I thought about working on it, but in the end I'm not
sure why we shouldn't just encourage people to self-tag their leading
commit line with some sort of standard key ([MC], [Target/Mips], whatever).

Very nice.

While at that, who can get rid of the [llvm],[cfe-commits], ... prefixes? I remember we agreed they just cost screen real estate.

That needs to be done by someone with admin access to the mailing lists, Chris, Tanya, John C., not sure who else?

 - Daniel
 

Tobi



_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Eli Bendersky
On Fri, Jan 25, 2013 at 4:07 PM, Daniel Dunbar <[hidden email]> wrote:

>
>
>
> On Fri, Jan 25, 2013 at 4:00 PM, Tobias Grosser <[hidden email]> wrote:
>>
>> On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
>>>
>>> Ok, this is done and seems to work.
>>>
>>> As far as Chris's request for getting "key directory" paths into the
>>> commit message, I thought about working on it, but in the end I'm not
>>> sure why we shouldn't just encourage people to self-tag their leading
>>> commit line with some sort of standard key ([MC], [Target/Mips],
>>> whatever).
>>
>>
>> Very nice.
>>
>> While at that, who can get rid of the [llvm],[cfe-commits], ... prefixes?
>> I remember we agreed they just cost screen real estate.
>

Careful here, these may be used to set up filters in mail clients, and
an alternative has to be provided.

For instance, I have a filter that sends all [compiler-rt] related
mail to its own folder, which is quite important for me.

Eli
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

David Blaikie
On Fri, Jan 25, 2013 at 4:28 PM, Eli Bendersky <[hidden email]> wrote:

> On Fri, Jan 25, 2013 at 4:07 PM, Daniel Dunbar <[hidden email]> wrote:
>>
>>
>>
>> On Fri, Jan 25, 2013 at 4:00 PM, Tobias Grosser <[hidden email]> wrote:
>>>
>>> On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
>>>>
>>>> Ok, this is done and seems to work.
>>>>
>>>> As far as Chris's request for getting "key directory" paths into the
>>>> commit message, I thought about working on it, but in the end I'm not
>>>> sure why we shouldn't just encourage people to self-tag their leading
>>>> commit line with some sort of standard key ([MC], [Target/Mips],
>>>> whatever).
>>>
>>>
>>> Very nice.
>>>
>>> While at that, who can get rid of the [llvm],[cfe-commits], ... prefixes?
>>> I remember we agreed they just cost screen real estate.
>>
>
> Careful here, these may be used to set up filters in mail clients, and
> an alternative has to be provided.

Agreed.

> For instance, I have a filter that sends all [compiler-rt] related
> mail to its own folder, which is quite important for me.

the [compiler-rt] prefix is for the specific repository, rather than
the mailing list - that would remain (it's part of the svn mail
sending process), but the mailing list prefix is a property of the
mailing list software overall, which is what's going to (potentially)
be removed.

That being said, even though I (& probably most gmail users) have
mailing list rules setup based on list headers rather than subject
prefixes, like you, I wouldn't be sure that everyone has this setup or
that it's convenient for everyone to do so.

I'd like this change, I'm just not sure how to evaluate whether it's
correct (short of changing it seeing how many people complain/how many
of them cannot be helped/fixed)
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Eli Bendersky
On Fri, Jan 25, 2013 at 4:37 PM, David Blaikie <[hidden email]> wrote:

> On Fri, Jan 25, 2013 at 4:28 PM, Eli Bendersky <[hidden email]> wrote:
>> On Fri, Jan 25, 2013 at 4:07 PM, Daniel Dunbar <[hidden email]> wrote:
>>>
>>>
>>>
>>> On Fri, Jan 25, 2013 at 4:00 PM, Tobias Grosser <[hidden email]> wrote:
>>>>
>>>> On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
>>>>>
>>>>> Ok, this is done and seems to work.
>>>>>
>>>>> As far as Chris's request for getting "key directory" paths into the
>>>>> commit message, I thought about working on it, but in the end I'm not
>>>>> sure why we shouldn't just encourage people to self-tag their leading
>>>>> commit line with some sort of standard key ([MC], [Target/Mips],
>>>>> whatever).
>>>>
>>>>
>>>> Very nice.
>>>>
>>>> While at that, who can get rid of the [llvm],[cfe-commits], ... prefixes?
>>>> I remember we agreed they just cost screen real estate.
>>>
>>
>> Careful here, these may be used to set up filters in mail clients, and
>> an alternative has to be provided.
>
> Agreed.
>
>> For instance, I have a filter that sends all [compiler-rt] related
>> mail to its own folder, which is quite important for me.
>
> the [compiler-rt] prefix is for the specific repository, rather than
> the mailing list - that would remain (it's part of the svn mail
> sending process), but the mailing list prefix is a property of the
> mailing list software overall, which is what's going to (potentially)
> be removed.
>

OK, I see.

> That being said, even though I (& probably most gmail users) have
> mailing list rules setup based on list headers rather than subject
> prefixes, like you, I wouldn't be sure that everyone has this setup or
> that it's convenient for everyone to do so.
>
> I'd like this change, I'm just not sure how to evaluate whether it's
> correct (short of changing it seeing how many people complain/how many
> of them cannot be helped/fixed)

I guess that the need can be summarized to:

- If email comes from separate email addresses (or "to" separate
addresses), further specification in the subject is superfluous and
can be nuked.
- If email is otherwise indistinguishable but comes from different
sub-projects, some specification in the subject has to be retained to
allow effective mailbox management.

What am I missing?

Eli
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Tobias Grosser-5
On 01/26/2013 01:41 AM, Eli Bendersky wrote:

> On Fri, Jan 25, 2013 at 4:37 PM, David Blaikie <[hidden email]> wrote:
>> On Fri, Jan 25, 2013 at 4:28 PM, Eli Bendersky <[hidden email]> wrote:
>>> On Fri, Jan 25, 2013 at 4:07 PM, Daniel Dunbar <[hidden email]> wrote:
>>>>
>>>>
>>>>
>>>> On Fri, Jan 25, 2013 at 4:00 PM, Tobias Grosser <[hidden email]> wrote:
>>>>>
>>>>> On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
>>>>>>
>>>>>> Ok, this is done and seems to work.
>>>>>>
>>>>>> As far as Chris's request for getting "key directory" paths into the
>>>>>> commit message, I thought about working on it, but in the end I'm not
>>>>>> sure why we shouldn't just encourage people to self-tag their leading
>>>>>> commit line with some sort of standard key ([MC], [Target/Mips],
>>>>>> whatever).
>>>>>
>>>>>
>>>>> Very nice.
>>>>>
>>>>> While at that, who can get rid of the [llvm],[cfe-commits], ... prefixes?
>>>>> I remember we agreed they just cost screen real estate.
>>>>
>>>
>>> Careful here, these may be used to set up filters in mail clients, and
>>> an alternative has to be provided.
>>
>> Agreed.
>>
>>> For instance, I have a filter that sends all [compiler-rt] related
>>> mail to its own folder, which is quite important for me.
>>
>> the [compiler-rt] prefix is for the specific repository, rather than
>> the mailing list - that would remain (it's part of the svn mail
>> sending process), but the mailing list prefix is a property of the
>> mailing list software overall, which is what's going to (potentially)
>> be removed.
>>
>
> OK, I see.
>
>> That being said, even though I (& probably most gmail users) have
>> mailing list rules setup based on list headers rather than subject
>> prefixes, like you, I wouldn't be sure that everyone has this setup or
>> that it's convenient for everyone to do so.
>>
>> I'd like this change, I'm just not sure how to evaluate whether it's
>> correct (short of changing it seeing how many people complain/how many
>> of them cannot be helped/fixed)
>
> I guess that the need can be summarized to:
>
> - If email comes from separate email addresses (or "to" separate
> addresses), further specification in the subject is superfluous and
> can be nuked.
> - If email is otherwise indistinguishable but comes from different
> sub-projects, some specification in the subject has to be retained to
> allow effective mailbox management.
>
> What am I missing?

I don't see anything missing.

I asked to remove the list name from the subject, as it is already
provided in the "List-Id" header of all mailing list emails and is
consequently redundant. The different svn sub-projects are useful and I
don't think we should remove this information.

Chris replied to that request earlier (15. Nov):

 > I agree that the list name is redundant and should be dropped, but
 > the revision number is compact and very useful...
 >
 > -Chris

If we agreed to perform this change and we found the person who can
change it, we can probably give a heads-up a couple of days before to
see if anybody will have major issues.

Cheers,
Tobi


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

David Blaikie
On Sat, Jan 26, 2013 at 6:22 AM, Tobias Grosser <[hidden email]> wrote:

> On 01/26/2013 01:41 AM, Eli Bendersky wrote:
>>
>> On Fri, Jan 25, 2013 at 4:37 PM, David Blaikie <[hidden email]> wrote:
>>>
>>> On Fri, Jan 25, 2013 at 4:28 PM, Eli Bendersky <[hidden email]> wrote:
>>>>
>>>> On Fri, Jan 25, 2013 at 4:07 PM, Daniel Dunbar <[hidden email]>
>>>> wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Jan 25, 2013 at 4:00 PM, Tobias Grosser <[hidden email]>
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>> On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
>>>>>>>
>>>>>>>
>>>>>>> Ok, this is done and seems to work.
>>>>>>>
>>>>>>> As far as Chris's request for getting "key directory" paths into the
>>>>>>> commit message, I thought about working on it, but in the end I'm not
>>>>>>> sure why we shouldn't just encourage people to self-tag their leading
>>>>>>> commit line with some sort of standard key ([MC], [Target/Mips],
>>>>>>> whatever).
>>>>>>
>>>>>>
>>>>>>
>>>>>> Very nice.
>>>>>>
>>>>>> While at that, who can get rid of the [llvm],[cfe-commits], ...
>>>>>> prefixes?
>>>>>> I remember we agreed they just cost screen real estate.
>>>>>
>>>>>
>>>>
>>>> Careful here, these may be used to set up filters in mail clients, and
>>>> an alternative has to be provided.
>>>
>>>
>>> Agreed.
>>>
>>>> For instance, I have a filter that sends all [compiler-rt] related
>>>> mail to its own folder, which is quite important for me.
>>>
>>>
>>> the [compiler-rt] prefix is for the specific repository, rather than
>>> the mailing list - that would remain (it's part of the svn mail
>>> sending process), but the mailing list prefix is a property of the
>>> mailing list software overall, which is what's going to (potentially)
>>> be removed.
>>>
>>
>> OK, I see.
>>
>>> That being said, even though I (& probably most gmail users) have
>>> mailing list rules setup based on list headers rather than subject
>>> prefixes, like you, I wouldn't be sure that everyone has this setup or
>>> that it's convenient for everyone to do so.
>>>
>>> I'd like this change, I'm just not sure how to evaluate whether it's
>>> correct (short of changing it seeing how many people complain/how many
>>> of them cannot be helped/fixed)
>>
>>
>> I guess that the need can be summarized to:
>>
>> - If email comes from separate email addresses (or "to" separate
>> addresses), further specification in the subject is superfluous and
>> can be nuked.
>> - If email is otherwise indistinguishable but comes from different
>> sub-projects, some specification in the subject has to be retained to
>> allow effective mailbox management.
>>
>> What am I missing?
>
>
> I don't see anything missing.
>
> I asked to remove the list name from the subject, as it is already provided
> in the "List-Id" header of all mailing list emails and is consequently
> redundant. The different svn sub-projects are useful and I don't think we
> should remove this information.
>
> Chris replied to that request earlier (15. Nov):
>
>
>> I agree that the list name is redundant and should be dropped, but
>> the revision number is compact and very useful...
>>
>> -Chris
>
> If we agreed to perform this change and we found the person who can change
> it, we can probably give a heads-up a couple of days before to see if
> anybody will have major issues.

SGTM - thanks for the recap/quotation. (but, yes, I'm not the person
who can change that - hopefully Tanya or one of the other admins will
speak up with details)
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Tanya Lattner-2

On Jan 26, 2013, at 9:49 AM, David Blaikie <[hidden email]> wrote:

> On Sat, Jan 26, 2013 at 6:22 AM, Tobias Grosser <[hidden email]> wrote:
>> On 01/26/2013 01:41 AM, Eli Bendersky wrote:
>>>
>>> On Fri, Jan 25, 2013 at 4:37 PM, David Blaikie <[hidden email]> wrote:
>>>>
>>>> On Fri, Jan 25, 2013 at 4:28 PM, Eli Bendersky <[hidden email]> wrote:
>>>>>
>>>>> On Fri, Jan 25, 2013 at 4:07 PM, Daniel Dunbar <[hidden email]>
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Jan 25, 2013 at 4:00 PM, Tobias Grosser <[hidden email]>
>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> Ok, this is done and seems to work.
>>>>>>>>
>>>>>>>> As far as Chris's request for getting "key directory" paths into the
>>>>>>>> commit message, I thought about working on it, but in the end I'm not
>>>>>>>> sure why we shouldn't just encourage people to self-tag their leading
>>>>>>>> commit line with some sort of standard key ([MC], [Target/Mips],
>>>>>>>> whatever).
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Very nice.
>>>>>>>
>>>>>>> While at that, who can get rid of the [llvm],[cfe-commits], ...
>>>>>>> prefixes?
>>>>>>> I remember we agreed they just cost screen real estate.
>>>>>>
>>>>>>
>>>>>
>>>>> Careful here, these may be used to set up filters in mail clients, and
>>>>> an alternative has to be provided.
>>>>
>>>>
>>>> Agreed.
>>>>
>>>>> For instance, I have a filter that sends all [compiler-rt] related
>>>>> mail to its own folder, which is quite important for me.
>>>>
>>>>
>>>> the [compiler-rt] prefix is for the specific repository, rather than
>>>> the mailing list - that would remain (it's part of the svn mail
>>>> sending process), but the mailing list prefix is a property of the
>>>> mailing list software overall, which is what's going to (potentially)
>>>> be removed.
>>>>
>>>
>>> OK, I see.
>>>
>>>> That being said, even though I (& probably most gmail users) have
>>>> mailing list rules setup based on list headers rather than subject
>>>> prefixes, like you, I wouldn't be sure that everyone has this setup or
>>>> that it's convenient for everyone to do so.
>>>>
>>>> I'd like this change, I'm just not sure how to evaluate whether it's
>>>> correct (short of changing it seeing how many people complain/how many
>>>> of them cannot be helped/fixed)
>>>
>>>
>>> I guess that the need can be summarized to:
>>>
>>> - If email comes from separate email addresses (or "to" separate
>>> addresses), further specification in the subject is superfluous and
>>> can be nuked.
>>> - If email is otherwise indistinguishable but comes from different
>>> sub-projects, some specification in the subject has to be retained to
>>> allow effective mailbox management.
>>>
>>> What am I missing?
>>
>>
>> I don't see anything missing.
>>
>> I asked to remove the list name from the subject, as it is already provided
>> in the "List-Id" header of all mailing list emails and is consequently
>> redundant. The different svn sub-projects are useful and I don't think we
>> should remove this information.
>>
>> Chris replied to that request earlier (15. Nov):
>>
>>
>>> I agree that the list name is redundant and should be dropped, but
>>> the revision number is compact and very useful...
>>>
>>> -Chris
>>
>> If we agreed to perform this change and we found the person who can change
>> it, we can probably give a heads-up a couple of days before to see if
>> anybody will have major issues.
>
> SGTM - thanks for the recap/quotation. (but, yes, I'm not the person
> who can change that - hopefully Tanya or one of the other admins will
> speak up with details)


Yes, I can remove the list name. I'll confirm with Chris and I can send email to the lists before it is done. Sound ok?

-Tanya


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Tobias Grosser-5
On 01/27/2013 12:20 AM, Tanya Lattner wrote:

>
> On Jan 26, 2013, at 9:49 AM, David Blaikie <[hidden email]> wrote:
>
>> On Sat, Jan 26, 2013 at 6:22 AM, Tobias Grosser <[hidden email]> wrote:
>>> On 01/26/2013 01:41 AM, Eli Bendersky wrote:
>>>>
>>>> On Fri, Jan 25, 2013 at 4:37 PM, David Blaikie <[hidden email]> wrote:
>>>>>
>>>>> On Fri, Jan 25, 2013 at 4:28 PM, Eli Bendersky <[hidden email]> wrote:
>>>>>>
>>>>>> On Fri, Jan 25, 2013 at 4:07 PM, Daniel Dunbar <[hidden email]>
>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Jan 25, 2013 at 4:00 PM, Tobias Grosser <[hidden email]>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Ok, this is done and seems to work.
>>>>>>>>>
>>>>>>>>> As far as Chris's request for getting "key directory" paths into the
>>>>>>>>> commit message, I thought about working on it, but in the end I'm not
>>>>>>>>> sure why we shouldn't just encourage people to self-tag their leading
>>>>>>>>> commit line with some sort of standard key ([MC], [Target/Mips],
>>>>>>>>> whatever).
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Very nice.
>>>>>>>>
>>>>>>>> While at that, who can get rid of the [llvm],[cfe-commits], ...
>>>>>>>> prefixes?
>>>>>>>> I remember we agreed they just cost screen real estate.
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> Careful here, these may be used to set up filters in mail clients, and
>>>>>> an alternative has to be provided.
>>>>>
>>>>>
>>>>> Agreed.
>>>>>
>>>>>> For instance, I have a filter that sends all [compiler-rt] related
>>>>>> mail to its own folder, which is quite important for me.
>>>>>
>>>>>
>>>>> the [compiler-rt] prefix is for the specific repository, rather than
>>>>> the mailing list - that would remain (it's part of the svn mail
>>>>> sending process), but the mailing list prefix is a property of the
>>>>> mailing list software overall, which is what's going to (potentially)
>>>>> be removed.
>>>>>
>>>>
>>>> OK, I see.
>>>>
>>>>> That being said, even though I (& probably most gmail users) have
>>>>> mailing list rules setup based on list headers rather than subject
>>>>> prefixes, like you, I wouldn't be sure that everyone has this setup or
>>>>> that it's convenient for everyone to do so.
>>>>>
>>>>> I'd like this change, I'm just not sure how to evaluate whether it's
>>>>> correct (short of changing it seeing how many people complain/how many
>>>>> of them cannot be helped/fixed)
>>>>
>>>>
>>>> I guess that the need can be summarized to:
>>>>
>>>> - If email comes from separate email addresses (or "to" separate
>>>> addresses), further specification in the subject is superfluous and
>>>> can be nuked.
>>>> - If email is otherwise indistinguishable but comes from different
>>>> sub-projects, some specification in the subject has to be retained to
>>>> allow effective mailbox management.
>>>>
>>>> What am I missing?
>>>
>>>
>>> I don't see anything missing.
>>>
>>> I asked to remove the list name from the subject, as it is already provided
>>> in the "List-Id" header of all mailing list emails and is consequently
>>> redundant. The different svn sub-projects are useful and I don't think we
>>> should remove this information.
>>>
>>> Chris replied to that request earlier (15. Nov):
>>>
>>>
>>>> I agree that the list name is redundant and should be dropped, but
>>>> the revision number is compact and very useful...
>>>>
>>>> -Chris
>>>
>>> If we agreed to perform this change and we found the person who can change
>>> it, we can probably give a heads-up a couple of days before to see if
>>> anybody will have major issues.
>>
>> SGTM - thanks for the recap/quotation. (but, yes, I'm not the person
>> who can change that - hopefully Tanya or one of the other admins will
>> speak up with details)
>
>
> Yes, I can remove the list name. I'll confirm with Chris and I can send email to the lists before it is done. Sound ok?

Sounds great. Thanks Tanya!

Tobi

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Chris Lattner-2
In reply to this post by Tanya Lattner-2
On Jan 26, 2013, at 3:20 PM, Tanya Lattner <[hidden email]> wrote:

>>>
>>>> I agree that the list name is redundant and should be dropped, but
>>>> the revision number is compact and very useful...
>>>>
>>>> -Chris
>>>
>>> If we agreed to perform this change and we found the person who can change
>>> it, we can probably give a heads-up a couple of days before to see if
>>> anybody will have major issues.
>>
>> SGTM - thanks for the recap/quotation. (but, yes, I'm not the person
>> who can change that - hopefully Tanya or one of the other admins will
>> speak up with details)
>
>
> Yes, I can remove the list name. I'll confirm with Chris and I can send email to the lists before it is done. Sound ok?

Would it make sense to remove [llvm-commits] and [cfe-commits], but keep [polly], [poolalloc], [libc++] etc?    That way, the common case is more compact, but the other repos are still distinguishable.

-Chris
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

David Blaikie
On Mon, Jan 28, 2013 at 9:48 AM, Chris Lattner <[hidden email]> wrote:

> On Jan 26, 2013, at 3:20 PM, Tanya Lattner <[hidden email]> wrote:
>>>>
>>>>> I agree that the list name is redundant and should be dropped, but
>>>>> the revision number is compact and very useful...
>>>>>
>>>>> -Chris
>>>>
>>>> If we agreed to perform this change and we found the person who can change
>>>> it, we can probably give a heads-up a couple of days before to see if
>>>> anybody will have major issues.
>>>
>>> SGTM - thanks for the recap/quotation. (but, yes, I'm not the person
>>> who can change that - hopefully Tanya or one of the other admins will
>>> speak up with details)
>>
>>
>> Yes, I can remove the list name. I'll confirm with Chris and I can send email to the lists before it is done. Sound ok?
>
> Would it make sense to remove [llvm-commits] and [cfe-commits], but keep [polly], [poolalloc], [libc++] etc?    That way, the common case is more compact, but the other repos are still distinguishable.

I'm assuming this will already be the case - perhaps I'm
misunderstanding something though. I was assuming that the [pool]
[poolalloc] [libc++] prefixes were added by the SVN mailing software
(which we're not planning to touch) and the [llvm-commits],
[cfe-commits], [llvm-dev], [cfe-dev], [cfe-users] prefixes are handled
by the mailing list software which we'll modify/reconfigure to not
include any of the prefixes.
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [cfe-dev] RFC: put commit messages in *-commits subject lines?

Tanya Lattner-2

On Jan 28, 2013, at 9:56 AM, David Blaikie <[hidden email]> wrote:

> On Mon, Jan 28, 2013 at 9:48 AM, Chris Lattner <[hidden email]> wrote:
>> On Jan 26, 2013, at 3:20 PM, Tanya Lattner <[hidden email]> wrote:
>>>>>
>>>>>> I agree that the list name is redundant and should be dropped, but
>>>>>> the revision number is compact and very useful...
>>>>>>
>>>>>> -Chris
>>>>>
>>>>> If we agreed to perform this change and we found the person who can change
>>>>> it, we can probably give a heads-up a couple of days before to see if
>>>>> anybody will have major issues.
>>>>
>>>> SGTM - thanks for the recap/quotation. (but, yes, I'm not the person
>>>> who can change that - hopefully Tanya or one of the other admins will
>>>> speak up with details)
>>>
>>>
>>> Yes, I can remove the list name. I'll confirm with Chris and I can send email to the lists before it is done. Sound ok?
>>
>> Would it make sense to remove [llvm-commits] and [cfe-commits], but keep [polly], [poolalloc], [libc++] etc?    That way, the common case is more compact, but the other repos are still distinguishable.
>
> I'm assuming this will already be the case - perhaps I'm
> misunderstanding something though. I was assuming that the [pool]
> [poolalloc] [libc++] prefixes were added by the SVN mailing software
> (which we're not planning to touch) and the [llvm-commits],
> [cfe-commits], [llvm-dev], [cfe-dev], [cfe-users] prefixes are handled
> by the mailing list software which we'll modify/reconfigure to not
> include any of the prefixes.


I thought we were removing just the list name too. I am going to do this shortly.

-Tanya


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
123