PATCH: X86 calling convention cleanup

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

PATCH: X86 calling convention cleanup

Gordon Henriksen-3
The four X86 calling convention implementations in X86ISelLowering.cpp  
contain several hundred lines of duplicated code. This patch refines  
the copies so that diff reveals refactoring opportunities instead of  
noise. Okay to commit?

(My goal is to introduce a crazy new ABI.)

— Gordon





_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

cconv.patch (23K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: PATCH: X86 calling convention cleanup

Evan Cheng-2
Yes, looks good to me.

Thanks for signing up to do the refactoring! I know this code can use  
a good scrubbing.

Evan

On Dec 30, 2007, at 11:25 PM, Gordon Henriksen wrote:

> The four X86 calling convention implementations in  
> X86ISelLowering.cpp contain several hundred lines of duplicated  
> code. This patch refines the copies so that diff reveals refactoring  
> opportunities instead of noise. Okay to commit?
>
> (My goal is to introduce a crazy new ABI.)
>
> — Gordon
>
>
> <cconv.patch>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev