[PATCH] Mach-O Identify File Type

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Mach-O Identify File Type

Jean-Daniel Dupas-2
An improved Mach-O file type detection for sys::IdentifyFileType()
This patch add supports for single architecture mach-o files (the  
current implementation only support Universal Binary), and solve the  
signature conflict between java class and Universal Binary magics.

Note that this function will always returned dynamic library for  
Universal Binaries (like the current implementation) because the  
binary type is not include in the file header.






_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

MachOFile.diff (2K) Download Attachment
smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Mach-O Identify File Type

Chris Lattner

On Jun 25, 2008, at 4:59 PM, Jean-Daniel Dupas wrote:

> An improved Mach-O file type detection for sys::IdentifyFileType()
> This patch add supports for single architecture mach-o files (the  
> current implementation only support Universal Binary), and solve the  
> signature conflict between java class and Universal Binary magics.
>
> Note that this function will always returned dynamic library for  
> Universal Binaries (like the current implementation) because the  
> binary type is not include in the file header.

Applied, thanks!
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080623/064180.html

-Chris
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Mach-O Identify File Type

Jean-Daniel Dupas-2

Le 26 juin 08 à 07:17, Chris Lattner a écrit :

>
> On Jun 25, 2008, at 4:59 PM, Jean-Daniel Dupas wrote:
>
>> An improved Mach-O file type detection for sys::IdentifyFileType()
>> This patch add supports for single architecture mach-o files (the
>> current implementation only support Universal Binary), and solve the
>> signature conflict between java class and Universal Binary magics.
>>
>> Note that this function will always returned dynamic library for
>> Universal Binaries (like the current implementation) because the
>> binary type is not include in the file header.
>
> Applied, thanks!
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080623/064180.html
>
> -Chris
Woops, sorry, I miss a "type can be used uninitialized" warning.





_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

MachoType.diff (1K) Download Attachment
smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Mach-O Identify File Type

Bill Wendling
On Jun 26, 2008, at 1:03 AM, Jean-Daniel Dupas wrote:

>
> Le 26 juin 08 à 07:17, Chris Lattner a écrit :
>
>>
>> On Jun 25, 2008, at 4:59 PM, Jean-Daniel Dupas wrote:
>>
>>> An improved Mach-O file type detection for sys::IdentifyFileType()
>>> This patch add supports for single architecture mach-o files (the
>>> current implementation only support Universal Binary), and solve the
>>> signature conflict between java class and Universal Binary magics.
>>>
>>> Note that this function will always returned dynamic library for
>>> Universal Binaries (like the current implementation) because the
>>> binary type is not include in the file header.
>>
>> Applied, thanks!
>> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080623/064180.html
>>
>> -Chris
>
> Woops, sorry, I miss a "type can be used uninitialized" warning.
>
Applied. Merci encore! ;-)

-bw
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Mach-O Identify File Type

Mike Stump
In reply to this post by Jean-Daniel Dupas-2
On Jun 25, 2008, at 4:59 PM, Jean-Daniel Dupas wrote:
> An improved Mach-O file type detection for sys::IdentifyFileType()

Odd, your message doesn't verify.
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Mach-O Identify File Type

Jean-Daniel Dupas-2
What do you mean ?

Le 26 juin 08 à 21:25, Mike Stump a écrit :

> On Jun 25, 2008, at 4:59 PM, Jean-Daniel Dupas wrote:
>> An improved Mach-O file type detection for sys::IdentifyFileType()
>
> Odd, your message doesn't verify.
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Mach-O Identify File Type

Mike Stump
On Jun 26, 2008, at 2:35 PM, Jean-Daniel Dupas wrote:
> What do you mean ?

The message that was sent was signed, that signature didn't validate  
with my signature checker.  Could be my mail reader, could be the list  
software, could be something else....  just thought you'd like to  
know.  Be curious if it validated for others, or if it's just me.
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Mach-O Identify File Type

Ted Kremenek-2

On Jun 27, 2008, at 12:27 PM, Mike Stump wrote:

> On Jun 26, 2008, at 2:35 PM, Jean-Daniel Dupas wrote:
>> What do you mean ?
>
> The message that was sent was signed, that signature didn't validate
> with my signature checker.  Could be my mail reader, could be the list
> software, could be something else....  just thought you'd like to
> know.  Be curious if it validated for others, or if it's just me.

Mike: It's not just you.  The message didn't validate for me as well.  
Of course, we're both using the same mail client (Mail on Mac OS X).

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev