3.5.1 Testing Phase II Begins

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
34 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Daniel Sanders
> Just for the record: http://reviews.llvm.org/D6812 fixes most of these big-
> endian N32 failures but we should stick to the current plan because I haven't
> retested the other ABI's yet.
> All but one of the remaining failures is due a qemu bug. The linux user mode
> emulation of struct target_stat doesn't quite match any supported by glibc and
> causes certain stat() calls to return -1.
> This is fixed in my working copy of qemu and I'll upstream it soon. The last
> failure is that lemon's output is wrong. I don't know the cause yet.

The lemon failure turned out to be caused by treating transparent unions as a normal union type and not as the type of the first member. This caused wait() to return 0 without writing an exit code to the given pointer. I'm about to commit a fix to trunk for this.

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Nikola Smiljanic
Was there an rc3 that I missed?

On Wed, Jan 14, 2015 at 10:20 PM, Daniel Sanders <[hidden email]> wrote:
> Just for the record: http://reviews.llvm.org/D6812 fixes most of these big-
> endian N32 failures but we should stick to the current plan because I haven't
> retested the other ABI's yet.
> All but one of the remaining failures is due a qemu bug. The linux user mode
> emulation of struct target_stat doesn't quite match any supported by glibc and
> causes certain stat() calls to return -1.
> This is fixed in my working copy of qemu and I'll upstream it soon. The last
> failure is that lemon's output is wrong. I don't know the cause yet.

The lemon failure turned out to be caused by treating transparent unions as a normal union type and not as the type of the first member. This caused wait() to return 0 without writing an exit code to the given pointer. I'm about to commit a fix to trunk for this.


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Ben Pope

On Thursday, January 15, 2015 06:55 AM, Nikola Smiljanic wrote:
> Was there an rc3 that I missed?
>

It's not tagged if there was.

I've tested and uploaded 3.5.1 final for x86_64-ubuntu-14.04. I think
the rc2 build required a newer libstdc++ than exists on Ubuntu 14.04,
but the final build should be good.

Ben
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Nikola Smiljanic
In that case are we supposed to build final binaries for 3.5.1?

On Thu, Jan 15, 2015 at 11:49 AM, Ben Pope <[hidden email]> wrote:

On Thursday, January 15, 2015 06:55 AM, Nikola Smiljanic wrote:
Was there an rc3 that I missed?


It's not tagged if there was.

I've tested and uploaded 3.5.1 final for x86_64-ubuntu-14.04. I think the rc2 build required a newer libstdc++ than exists on Ubuntu 14.04, but the final build should be good.

Ben


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Daniel Sanders

> In that case are we supposed to build final binaries for 3.5.1?

 

I believe so. At least, I did for 3.4 and 3.5.0 and nobody said I didn’t need to. It should only affect the --version string and the package filename.

 

From: Nikola Smiljanic [mailto:[hidden email]]
Sent: 15 January 2015 00:50
To: Ben Pope
Cc: Daniel Sanders; Tom Stellard; llvmdev
Subject: Re: [LLVMdev] 3.5.1 Testing Phase II Begins

 

In that case are we supposed to build final binaries for 3.5.1?

 

On Thu, Jan 15, 2015 at 11:49 AM, Ben Pope <[hidden email]> wrote:


On Thursday, January 15, 2015 06:55 AM, Nikola Smiljanic wrote:

Was there an rc3 that I missed?


It's not tagged if there was.

I've tested and uploaded 3.5.1 final for x86_64-ubuntu-14.04. I think the rc2 build required a newer libstdc++ than exists on Ubuntu 14.04, but the final build should be good.

Ben

 


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Sylvestre Ledru-6
In reply to this post by Nikola Smiljanic
Many of them are already live:
http://llvm.org/releases/download.html#3.5

On 15/01/2015 01:50, Nikola Smiljanic wrote:
In that case are we supposed to build final binaries for 3.5.1?

On Thu, Jan 15, 2015 at 11:49 AM, Ben Pope <[hidden email]> wrote:

On Thursday, January 15, 2015 06:55 AM, Nikola Smiljanic wrote:
Was there an rc3 that I missed?


It's not tagged if there was.

I've tested and uploaded 3.5.1 final for x86_64-ubuntu-14.04. I think the rc2 build required a newer libstdc++ than exists on Ubuntu 14.04, but the final build should be good.

Ben



_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Daniel Sanders

I don't see any 3.5.1 releases on that page. Only 3.5.0 and earlier.

 

From: [hidden email] [mailto:[hidden email]] On Behalf Of Sylvestre Ledru
Sent: 15 January 2015 10:40
To: Nikola Smiljanic; Ben Pope
Cc: llvmdev
Subject: Re: [LLVMdev] 3.5.1 Testing Phase II Begins

 

Many of them are already live:
http://llvm.org/releases/download.html#3.5

On 15/01/2015 01:50, Nikola Smiljanic wrote:

In that case are we supposed to build final binaries for 3.5.1?

 

On Thu, Jan 15, 2015 at 11:49 AM, Ben Pope <[hidden email]> wrote:


On Thursday, January 15, 2015 06:55 AM, Nikola Smiljanic wrote:

Was there an rc3 that I missed?


It's not tagged if there was.

I've tested and uploaded 3.5.1 final for x86_64-ubuntu-14.04. I think the rc2 build required a newer libstdc++ than exists on Ubuntu 14.04, but the final build should be good.

Ben

 




_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

 


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Ben Pope
On Thursday, January 15, 2015 06:57 PM, Daniel Sanders wrote:
 > I don't see any 3.5.1 releases on that page. Only 3.5.0 and earlier.

They're definitely there now, I just checked.

http://llvm.org/releases/download.html#3.5.1

Ben

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Daniel Sanders
In that case something strange is happening. I still have the 'SVN Access' section followed by 'Download LLVM 3.5.0'. I'll look into it.

> -----Original Message-----
> From: Ben Pope [mailto:[hidden email]]
> Sent: 15 January 2015 11:14
> To: Daniel Sanders; Sylvestre Ledru; Nikola Smiljanic
> Cc: llvmdev
> Subject: Re: 3.5.1 Testing Phase II Begins
>
> On Thursday, January 15, 2015 06:57 PM, Daniel Sanders wrote:
>  > I don't see any 3.5.1 releases on that page. Only 3.5.0 and earlier.
>
> They're definitely there now, I just checked.
>
> http://llvm.org/releases/download.html#3.5.1
>
> Ben

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Daniel Sanders
In reply to this post by Ben Pope
I see the 3.5.1 releases from my phone at least.

> -----Original Message-----
> From: Daniel Sanders
> Sent: 15 January 2015 11:16
> To: 'Ben Pope'; Sylvestre Ledru; Nikola Smiljanic
> Cc: llvmdev
> Subject: RE: 3.5.1 Testing Phase II Begins
>
> In that case something strange is happening. I still have the 'SVN Access'
> section followed by 'Download LLVM 3.5.0'. I'll look into it.
>
> > -----Original Message-----
> > From: Ben Pope [mailto:[hidden email]]
> > Sent: 15 January 2015 11:14
> > To: Daniel Sanders; Sylvestre Ledru; Nikola Smiljanic
> > Cc: llvmdev
> > Subject: Re: 3.5.1 Testing Phase II Begins
> >
> > On Thursday, January 15, 2015 06:57 PM, Daniel Sanders wrote:
> >  > I don't see any 3.5.1 releases on that page. Only 3.5.0 and earlier.
> >
> > They're definitely there now, I just checked.
> >
> > http://llvm.org/releases/download.html#3.5.1
> >
> > Ben

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

sebastian.dressler
In reply to this post by Ben Pope
Hi,

I uploaded the 3.5.1 binary for OS X. Tested without failures.

Cheers,
Sebastian

2015-01-15 1:49 GMT+01:00 Ben Pope <[hidden email]>:

>
> On Thursday, January 15, 2015 06:55 AM, Nikola Smiljanic wrote:
>>
>> Was there an rc3 that I missed?
>>
>
> It's not tagged if there was.
>
> I've tested and uploaded 3.5.1 final for x86_64-ubuntu-14.04. I think the
> rc2 build required a newer libstdc++ than exists on Ubuntu 14.04, but the
> final build should be good.
>
> Ben
>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Tom Stellard-3
In reply to this post by Nikola Smiljanic
On Thu, Jan 15, 2015 at 11:50:29AM +1100, Nikola Smiljanic wrote:
> In that case are we supposed to build final binaries for 3.5.1?
>

No, the -final and -rc2 tags are equivalent, so I just posted the -rc2
binaries.

-Tom

> On Thu, Jan 15, 2015 at 11:49 AM, Ben Pope <[hidden email]> wrote:
>
> >
> > On Thursday, January 15, 2015 06:55 AM, Nikola Smiljanic wrote:
> >
> >> Was there an rc3 that I missed?
> >>
> >>
> > It's not tagged if there was.
> >
> > I've tested and uploaded 3.5.1 final for x86_64-ubuntu-14.04. I think the
> > rc2 build required a newer libstdc++ than exists on Ubuntu 14.04, but the
> > final build should be good.
> >
> > Ben
> >
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Tom Stellard-3
In reply to this post by David Majnemer
On Mon, Dec 29, 2014 at 02:52:37PM -0500, David Majnemer wrote:
> The most relevant of these is r222856 which reverted a set of broken
> optimizations in r210006.  I'd be happy with just including r222856.
> Optionally, we could take r222868 and r222871 which correctly restore the
> optimization.
>

Hi David,

I planning on doing a 3.5.2 release, so I think r222868 and r222871 can be
merged to the 3.5 branch too if Chandler approves.

-Tom

> On Mon, Dec 29, 2014 at 2:39 PM, Chandler Carruth <[hidden email]>
> wrote:
>
> > Hey Tom,
> >
> > David has pointed out to me that we have some *really* bad bugs in
> > instcombine in 3.5 that are starting to seriously impact users.
> > http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM
> > itself doesn't trip over this bug, and I suspect an innocent change to LLVM
> > could result in that.
> >
> > Do you think it's possible to spin a rc3 with a couple more patches to fix
> > this? I think David has already curated the patches and would be willing to
> > ensure they merge cleanly. I'm going to help review them as OK. My hope is
> > that this won't require a huge delay in 3.5.1, but what do you think?
> >
> > -Chandler
> >
> > On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
> >
> >> Hi,
> >>
> >> I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> >> branch of the test-suite.  If you have any questions, let me know.
> >>
> >> -Tom
> >> _______________________________________________
> >> LLVM Developers mailing list
> >> [hidden email]         http://llvm.cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >>
> >
> >
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Chilledheart
Hi

    I noticed that the announce of release 3.5.1 is there one week ago
    (http://lists.cs.uiuc.edu/pipermail/llvm-announce/2015-January/000056.html)
    and the final binaries are also available, or to be precise,
    downloadable at http://llvm.org/releases/3.5.1/ .

    However I could not found the freebsd and darwin binaries the last
    time I checked there.
    Just to be kind of curious, were they missing by mistake?

    Anyway, I am not urge about that. I have found the brand-new release
    3.6.0-rc2 (which has full kinds of binaries as usual, from
    http://llvm.org/pre-releases/3.6.0/ ) and switched to it already.

--
  Cheers,
Chilledheart

On Mon, Jan 19, 2015, at 22:50, Tom Stellard wrote:

> On Mon, Dec 29, 2014 at 02:52:37PM -0500, David Majnemer wrote:
> > The most relevant of these is r222856 which reverted a set of broken
> > optimizations in r210006.  I'd be happy with just including r222856.
> > Optionally, we could take r222868 and r222871 which correctly restore the
> > optimization.
> >
>
> Hi David,
>
> I planning on doing a 3.5.2 release, so I think r222868 and r222871 can
> be
> merged to the 3.5 branch too if Chandler approves.
>
> -Tom
>
> > On Mon, Dec 29, 2014 at 2:39 PM, Chandler Carruth <[hidden email]>
> > wrote:
> >
> > > Hey Tom,
> > >
> > > David has pointed out to me that we have some *really* bad bugs in
> > > instcombine in 3.5 that are starting to seriously impact users.
> > > http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM
> > > itself doesn't trip over this bug, and I suspect an innocent change to LLVM
> > > could result in that.
> > >
> > > Do you think it's possible to spin a rc3 with a couple more patches to fix
> > > this? I think David has already curated the patches and would be willing to
> > > ensure they merge cleanly. I'm going to help review them as OK. My hope is
> > > that this won't require a huge delay in 3.5.1, but what do you think?
> > >
> > > -Chandler
> > >
> > > On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
> > >
> > >> Hi,
> > >>
> > >> I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> > >> branch of the test-suite.  If you have any questions, let me know.
> > >>
> > >> -Tom
> > >> _______________________________________________
> > >> LLVM Developers mailing list
> > >> [hidden email]         http://llvm.cs.uiuc.edu
> > >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> > >>
> > >
> > >
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
12