3.5.1 Testing Phase II Begins

classic Classic list List threaded Threaded
34 messages Options
12
Reply | Threaded
Open this post in threaded view
|

3.5.1 Testing Phase II Begins

Tom Stellard-3
Hi,

I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
branch of the test-suite.  If you have any questions, let me know.

-Tom
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Hans Wennborg-2
On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
> Hi,
>
> I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> branch of the test-suite.  If you have any questions, let me know.

I've uploaded the Windows installer to the sftp with sha1:
b56681a457954916ac9c8f0d36426cde0a21ee1d  LLVM-3.5.1-rc2-win32.exe

Build worked fine this time. The only failing lit test is
Modules/compiler_builtins.m, which I guess is PR20995. That's probably
not cause for concern, but maybe we should remove the test from the
branch for those who build from source? CC'ing Yaron who has looked at
the PR some.

 - Hans
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Daniel Sanders
I've uploaded clang+llvm-3.5.1-rc2-mips-linux-gnu.tar.xz and clang+llvm-3.5.1-rc2-mipsel-linux-gnu.tar.xz. The latter fails prune.m in 'make check-all' as it did last time but this is because the 'touch -a' command isn't actually changing the access timestamp.

I've started the test-suite for both of them.
________________________________________
From: [hidden email] [[hidden email]] on behalf of Hans Wennborg [[hidden email]]
Sent: 19 December 2014 23:50
To: Tom Stellard
Cc: Ben Pope; Nikola Smiljanic; llvmdev
Subject: Re: [LLVMdev] 3.5.1 Testing Phase II Begins

On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
> Hi,
>
> I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> branch of the test-suite.  If you have any questions, let me know.

I've uploaded the Windows installer to the sftp with sha1:
b56681a457954916ac9c8f0d36426cde0a21ee1d  LLVM-3.5.1-rc2-win32.exe

Build worked fine this time. The only failing lit test is
Modules/compiler_builtins.m, which I guess is PR20995. That's probably
not cause for concern, but maybe we should remove the test from the
branch for those who build from source? CC'ing Yaron who has looked at
the PR some.

 - Hans
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Ben Pope
In reply to this post by Tom Stellard-3
On Saturday, December 20, 2014 06:35 AM, Tom Stellard wrote:
Hi,

I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
branch of the test-suite.  If you have any questions, let me know.

-Tom

uploads/clang+llvm-3.5.1-rc2-x86_64-linux-gnu-ubuntu-14.04.tar.xz

The tests all pass, but there seems to be a significant runtime performance regression in MultiSource/Benchmarks/nbench/nbench since rc1 (it's a long running test that's about 50% slower).

Ben

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Nikola Smiljanic
Uploaded Fedora and OpenSUSE last night, all looks good.

On Mon, Dec 22, 2014 at 2:47 PM, Ben Pope <[hidden email]> wrote:
On Saturday, December 20, 2014 06:35 AM, Tom Stellard wrote:
Hi,

I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
branch of the test-suite.  If you have any questions, let me know.

-Tom

uploads/clang+llvm-3.5.1-rc2-x86_64-linux-gnu-ubuntu-14.04.tar.xz

The tests all pass, but there seems to be a significant runtime performance regression in MultiSource/Benchmarks/nbench/nbench since rc1 (it's a long running test that's about 50% slower).

Ben


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

sebastian.dressler
Hi everyone,

I ran tests on OS X, no failures. Uploaded the binaries to my dropbox,
as I'm not on my usual machine, so could someone please move it to
SFTP? DL link: https://www.dropbox.com/s/ejpq33x85tkvfnb/clang%2Bllvm-3.5.1-rc2-x86_64-apple-darwin.tar.xz?dl=0
(MD5: a9123aaefd6b8c2c8db1173809d4a26d)

Merry christmas & Cheers,
Sebastian

2014-12-22 4:52 GMT+01:00 Nikola Smiljanic <[hidden email]>:

> Uploaded Fedora and OpenSUSE last night, all looks good.
>
> On Mon, Dec 22, 2014 at 2:47 PM, Ben Pope <[hidden email]> wrote:
>>
>> On Saturday, December 20, 2014 06:35 AM, Tom Stellard wrote:
>>
>> Hi,
>>
>> I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
>> branch of the test-suite.  If you have any questions, let me know.
>>
>> -Tom
>>
>>
>> uploads/clang+llvm-3.5.1-rc2-x86_64-linux-gnu-ubuntu-14.04.tar.xz
>>
>> The tests all pass, but there seems to be a significant runtime
>> performance regression in MultiSource/Benchmarks/nbench/nbench since rc1
>> (it's a long running test that's about 50% slower).
>>
>> Ben
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Daniel Sanders
In reply to this post by Daniel Sanders
clang+llvm-3.5.1-rc2-mips-linux-gnu.tar.xz:
    All ok for default options and -mips32.

clang+llvm-3.5.1-rc2-mipsel-linux-gnu.tar.xz:
    All ok for default options.
    It will take a couple days to get results for the -mips32 test-suite (there's no FPU or local disk on this machine so some tests take a very long time).

clang+llvm-3.5.1-rc2-x86_64-linux-gnu-ubuntu-14.04.tar.xz (cross-compiling to Mips):
    All ok for all ISA's more recent than mips32, all ABI's except big-endian N32*, and both endians.

* I seem to have mis-stated the results for rc1 for the big-endian N32 ABI, sorry. It fails 12 tests (previously I stated 'all ok' but looking at those log files again, this was incorrect) and the failing tests seem to involve pointers passed in varargs. This is a regression from 3.5.0 since it used to pass these tests, however this appears to be a small regression that's occurred as result of a major improvement to the big-endian N32 ABI (in particular, cross-linking with GCC now works in general). I therefore think we could leave this as a known issue and make sure it's fixed in 3.6.0 and 3.5.2.
Tom: Do you agree?
________________________________________
From: Daniel Sanders
Sent: 21 December 2014 12:30
To: Hans Wennborg; Tom Stellard
Cc: Ben Pope; Nikola Smiljanic; llvmdev
Subject: RE: [LLVMdev] 3.5.1 Testing Phase II Begins

I've uploaded clang+llvm-3.5.1-rc2-mips-linux-gnu.tar.xz and clang+llvm-3.5.1-rc2-mipsel-linux-gnu.tar.xz. The latter fails prune.m in 'make check-all' as it did last time but this is because the 'touch -a' command isn't actually changing the access timestamp.

I've started the test-suite for both of them.
________________________________________
From: [hidden email] [[hidden email]] on behalf of Hans Wennborg [[hidden email]]
Sent: 19 December 2014 23:50
To: Tom Stellard
Cc: Ben Pope; Nikola Smiljanic; llvmdev
Subject: Re: [LLVMdev] 3.5.1 Testing Phase II Begins

On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
> Hi,
>
> I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> branch of the test-suite.  If you have any questions, let me know.

I've uploaded the Windows installer to the sftp with sha1:
b56681a457954916ac9c8f0d36426cde0a21ee1d  LLVM-3.5.1-rc2-win32.exe

Build worked fine this time. The only failing lit test is
Modules/compiler_builtins.m, which I guess is PR20995. That's probably
not cause for concern, but maybe we should remove the test from the
branch for those who build from source? CC'ing Yaron who has looked at
the PR some.

 - Hans
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Sylvestre Ledru-6
In reply to this post by Tom Stellard-3
On 19/12/2014 23:35, Tom Stellard wrote:
> Hi,
>
> I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> branch of the test-suite.  If you have any questions, let me know.
>
>
Nothing special for Debian. 3.5.1 rc2 builds fine on (almost) all archs.

https://buildd.debian.org/status/package.php?p=llvm-toolchain-3.5&suite=experimental

Cheers,
Sylvestre

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Tom Stellard-3
In reply to this post by Daniel Sanders
On Tue, Dec 23, 2014 at 09:27:32PM +0000, Daniel Sanders wrote:

> clang+llvm-3.5.1-rc2-mips-linux-gnu.tar.xz:
>     All ok for default options and -mips32.
>
> clang+llvm-3.5.1-rc2-mipsel-linux-gnu.tar.xz:
>     All ok for default options.
>     It will take a couple days to get results for the -mips32 test-suite (there's no FPU or local disk on this machine so some tests take a very long time).
>
> clang+llvm-3.5.1-rc2-x86_64-linux-gnu-ubuntu-14.04.tar.xz (cross-compiling to Mips):
>     All ok for all ISA's more recent than mips32, all ABI's except big-endian N32*, and both endians.
>
> * I seem to have mis-stated the results for rc1 for the big-endian N32 ABI, sorry. It fails 12 tests (previously I stated 'all ok' but looking at those log files again, this was incorrect) and the failing tests seem to involve pointers passed in varargs. This is a regression from 3.5.0 since it used to pass these tests, however this appears to be a small regression that's occurred as result of a major improvement to the big-endian N32 ABI (in particular, cross-linking with GCC now works in general). I therefore think we could leave this as a known issue and make sure it's fixed in 3.6.0 and 3.5.2.
> Tom: Do you agree?

Yes, this sounds OK to me.

-Tom

> ________________________________________
> From: Daniel Sanders
> Sent: 21 December 2014 12:30
> To: Hans Wennborg; Tom Stellard
> Cc: Ben Pope; Nikola Smiljanic; llvmdev
> Subject: RE: [LLVMdev] 3.5.1 Testing Phase II Begins
>
> I've uploaded clang+llvm-3.5.1-rc2-mips-linux-gnu.tar.xz and clang+llvm-3.5.1-rc2-mipsel-linux-gnu.tar.xz. The latter fails prune.m in 'make check-all' as it did last time but this is because the 'touch -a' command isn't actually changing the access timestamp.
>
> I've started the test-suite for both of them.
> ________________________________________
> From: [hidden email] [[hidden email]] on behalf of Hans Wennborg [[hidden email]]
> Sent: 19 December 2014 23:50
> To: Tom Stellard
> Cc: Ben Pope; Nikola Smiljanic; llvmdev
> Subject: Re: [LLVMdev] 3.5.1 Testing Phase II Begins
>
> On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
> > Hi,
> >
> > I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> > branch of the test-suite.  If you have any questions, let me know.
>
> I've uploaded the Windows installer to the sftp with sha1:
> b56681a457954916ac9c8f0d36426cde0a21ee1d  LLVM-3.5.1-rc2-win32.exe
>
> Build worked fine this time. The only failing lit test is
> Modules/compiler_builtins.m, which I guess is PR20995. That's probably
> not cause for concern, but maybe we should remove the test from the
> branch for those who build from source? CC'ing Yaron who has looked at
> the PR some.
>
>  - Hans
> _______________________________________________
> LLVM Developers mailing list
> [hidden email]         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Tom Stellard-3
In reply to this post by Hans Wennborg-2
On Fri, Dec 19, 2014 at 03:50:30PM -0800, Hans Wennborg wrote:

> On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
> > Hi,
> >
> > I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> > branch of the test-suite.  If you have any questions, let me know.
>
> I've uploaded the Windows installer to the sftp with sha1:
> b56681a457954916ac9c8f0d36426cde0a21ee1d  LLVM-3.5.1-rc2-win32.exe
>
> Build worked fine this time. The only failing lit test is
> Modules/compiler_builtins.m, which I guess is PR20995. That's probably
> not cause for concern, but maybe we should remove the test from the
> branch for those who build from source? CC'ing Yaron who has looked at
> the PR some.
>

Did this test also fail in 3.5.0 and/or 3.5.1-rc1 ?

-Tom

>  - Hans
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Chandler Carruth-2
In reply to this post by Tom Stellard-3
Hey Tom,

David has pointed out to me that we have some *really* bad bugs in instcombine in 3.5 that are starting to seriously impact users. http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM itself doesn't trip over this bug, and I suspect an innocent change to LLVM could result in that.

Do you think it's possible to spin a rc3 with a couple more patches to fix this? I think David has already curated the patches and would be willing to ensure they merge cleanly. I'm going to help review them as OK. My hope is that this won't require a huge delay in 3.5.1, but what do you think?

-Chandler

On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
Hi,

I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
branch of the test-suite.  If you have any questions, let me know.

-Tom
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

David Majnemer
The most relevant of these is r222856 which reverted a set of broken optimizations in r210006.  I'd be happy with just including r222856.  Optionally, we could take r222868 and r222871 which correctly restore the optimization.

On Mon, Dec 29, 2014 at 2:39 PM, Chandler Carruth <[hidden email]> wrote:
Hey Tom,

David has pointed out to me that we have some *really* bad bugs in instcombine in 3.5 that are starting to seriously impact users. http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM itself doesn't trip over this bug, and I suspect an innocent change to LLVM could result in that.

Do you think it's possible to spin a rc3 with a couple more patches to fix this? I think David has already curated the patches and would be willing to ensure they merge cleanly. I'm going to help review them as OK. My hope is that this won't require a huge delay in 3.5.1, but what do you think?

-Chandler

On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
Hi,

I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
branch of the test-suite.  If you have any questions, let me know.

-Tom
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev



_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Chandler Carruth-2

On Mon, Dec 29, 2014 at 11:52 AM, David Majnemer <[hidden email]> wrote:
The most relevant of these is r222856 which reverted a set of broken optimizations in r210006.  I'd be happy with just including r222856.

FWIW, I've reviewed this and it is a very safe patch. I would approve it even at this late stage because (for example) they have exactly zero impact on different platforms, and so should require minimal testing. I think the only question is whether this creates an unreasonable disruption of the 3.5.1 release, and that's really a question for Tom.

  Optionally, we could take r222868 and r222871 which correctly restore the optimization.

These I don't think are reasonable at this stage IMO.

_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Tom Stellard-3
In reply to this post by Chandler Carruth-2
On Mon, Dec 29, 2014 at 11:39:42AM -0800, Chandler Carruth wrote:

> Hey Tom,
>
> David has pointed out to me that we have some *really* bad bugs in
> instcombine in 3.5 that are starting to seriously impact users.
> http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM
> itself doesn't trip over this bug, and I suspect an innocent change to LLVM
> could result in that.
>
> Do you think it's possible to spin a rc3 with a couple more patches to fix
> this? I think David has already curated the patches and would be willing to
> ensure they merge cleanly. I'm going to help review them as OK. My hope is
> that this won't require a huge delay in 3.5.1, but what do you think?
>

The release is already somewhat delayed due to the holidays.  I was hoping
-rc2 would be the last one, but there may be other issues anyway.

Do you have the list of patches that David wants to merge?  I will review them
and then he can merge them into the 3.5 branch so they are ready in case there
is an -rc3.

-Tom

> -Chandler
>
> On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
>
> > Hi,
> >
> > I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> > branch of the test-suite.  If you have any questions, let me know.
> >
> > -Tom
> > _______________________________________________
> > LLVM Developers mailing list
> > [hidden email]         http://llvm.cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Tom Stellard-3
In reply to this post by David Majnemer
On Mon, Dec 29, 2014 at 02:52:37PM -0500, David Majnemer wrote:
> The most relevant of these is r222856 which reverted a set of broken
> optimizations in r210006.  I'd be happy with just including r222856.

Go ahead and merge this one only.  If there is an -rc3, it will be included.

-Tom

> Optionally, we could take r222868 and r222871 which correctly restore the
> optimization.
>
> On Mon, Dec 29, 2014 at 2:39 PM, Chandler Carruth <[hidden email]>
> wrote:
>
> > Hey Tom,
> >
> > David has pointed out to me that we have some *really* bad bugs in
> > instcombine in 3.5 that are starting to seriously impact users.
> > http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM
> > itself doesn't trip over this bug, and I suspect an innocent change to LLVM
> > could result in that.
> >
> > Do you think it's possible to spin a rc3 with a couple more patches to fix
> > this? I think David has already curated the patches and would be willing to
> > ensure they merge cleanly. I'm going to help review them as OK. My hope is
> > that this won't require a huge delay in 3.5.1, but what do you think?
> >
> > -Chandler
> >
> > On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
> >
> >> Hi,
> >>
> >> I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> >> branch of the test-suite.  If you have any questions, let me know.
> >>
> >> -Tom
> >> _______________________________________________
> >> LLVM Developers mailing list
> >> [hidden email]         http://llvm.cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >>
> >
> >
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Dimitry Andric
In reply to this post by David Majnemer
In FreeBSD, I opted to import r222856 on top of 3.5.0 (see here).  This has the lowest impact, and fixed the most problematic case (libapr) for us.  I would really advise against doing a 3.5.1 release with this bug unfixed. :-)

-Dimitry

On 29 Dec 2014, at 20:52, David Majnemer <[hidden email]> wrote:

The most relevant of these is r222856 which reverted a set of broken optimizations in r210006.  I'd be happy with just including r222856.  Optionally, we could take r222868 and r222871 which correctly restore the optimization.

On Mon, Dec 29, 2014 at 2:39 PM, Chandler Carruth <[hidden email]> wrote:
Hey Tom,

David has pointed out to me that we have some *really* bad bugs in instcombine in 3.5 that are starting to seriously impact users. http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM itself doesn't trip over this bug, and I suspect an innocent change to LLVM could result in that.

Do you think it's possible to spin a rc3 with a couple more patches to fix this? I think David has already curated the patches and would be willing to ensure they merge cleanly. I'm going to help review them as OK. My hope is that this won't require a huge delay in 3.5.1, but what do you think?

-Chandler

On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
Hi,

I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
branch of the test-suite.  If you have any questions, let me know.

-Tom
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Hans Wennborg-2
In reply to this post by Tom Stellard-3
On Mon, Dec 29, 2014 at 8:57 AM, Tom Stellard <[hidden email]> wrote:

> On Fri, Dec 19, 2014 at 03:50:30PM -0800, Hans Wennborg wrote:
>> On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
>> > Hi,
>> >
>> > I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
>> > branch of the test-suite.  If you have any questions, let me know.
>>
>> I've uploaded the Windows installer to the sftp with sha1:
>> b56681a457954916ac9c8f0d36426cde0a21ee1d  LLVM-3.5.1-rc2-win32.exe
>>
>> Build worked fine this time. The only failing lit test is
>> Modules/compiler_builtins.m, which I guess is PR20995. That's probably
>> not cause for concern, but maybe we should remove the test from the
>> branch for those who build from source? CC'ing Yaron who has looked at
>> the PR some.
>>
>
> Did this test also fail in 3.5.0 and/or 3.5.1-rc1 ?

Yes, it fails both for 3.5.0 and 3.5.1-rc1.

 - Hans
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Renato Golin-2
In reply to this post by Tom Stellard-3
On 29 December 2014 at 20:15, Tom Stellard <[hidden email]> wrote:
> The release is already somewhat delayed due to the holidays.  I was hoping
> -rc2 would be the last one, but there may be other issues anyway.

Hi Tom,

Really sorry for the delay, but both ARM and AArch64 RC2 were
uploaded. Both green.

I'm ready for testing RC3.

cheers,
--renato
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

David Majnemer
In reply to this post by Tom Stellard-3
Done in r225255.

On Mon, Dec 29, 2014 at 1:46 PM, Tom Stellard <[hidden email]> wrote:
On Mon, Dec 29, 2014 at 02:52:37PM -0500, David Majnemer wrote:
> The most relevant of these is r222856 which reverted a set of broken
> optimizations in r210006.  I'd be happy with just including r222856.

Go ahead and merge this one only.  If there is an -rc3, it will be included.

-Tom

> Optionally, we could take r222868 and r222871 which correctly restore the
> optimization.
>
> On Mon, Dec 29, 2014 at 2:39 PM, Chandler Carruth <[hidden email]>
> wrote:
>
> > Hey Tom,
> >
> > David has pointed out to me that we have some *really* bad bugs in
> > instcombine in 3.5 that are starting to seriously impact users.
> > http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM
> > itself doesn't trip over this bug, and I suspect an innocent change to LLVM
> > could result in that.
> >
> > Do you think it's possible to spin a rc3 with a couple more patches to fix
> > this? I think David has already curated the patches and would be willing to
> > ensure they merge cleanly. I'm going to help review them as OK. My hope is
> > that this won't require a huge delay in 3.5.1, but what do you think?
> >
> > -Chandler
> >
> > On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <[hidden email]> wrote:
> >
> >> Hi,
> >>
> >> I've just tagged 3.5.1-rc2, so testing can begin.  Remember to use the 3.5
> >> branch of the test-suite.  If you have any questions, let me know.
> >>
> >> -Tom
> >> _______________________________________________
> >> LLVM Developers mailing list
> >> [hidden email]         http://llvm.cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >>
> >
> >


_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Reply | Threaded
Open this post in threaded view
|

Re: 3.5.1 Testing Phase II Begins

Daniel Sanders
In reply to this post by Tom Stellard-3
> From: Tom Stellard [[hidden email]]
> Sent: 29 December 2014 15:27
> To: Daniel Sanders
> Cc: Hans Wennborg; Ben Pope; Nikola Smiljanic; llvmdev
> Subject: Re: [LLVMdev] 3.5.1 Testing Phase II Begins
>
> On Tue, Dec 23, 2014 at 09:27:32PM +0000, Daniel Sanders wrote:
> > clang+llvm-3.5.1-rc2-mips-linux-gnu.tar.xz:
> >     All ok for default options and -mips32.
> >
> > clang+llvm-3.5.1-rc2-mipsel-linux-gnu.tar.xz:
> >     All ok for default options.
> >     It will take a couple days to get results for the -mips32 test-suite (there's no FPU or local disk on this machine so some tests take a very long time).
> >
> > clang+llvm-3.5.1-rc2-x86_64-linux-gnu-ubuntu-14.04.tar.xz (cross-compiling to Mips):
> >     All ok for all ISA's more recent than mips32, all ABI's except big-endian N32*, and both endians.
> >
> > * I seem to have mis-stated the results for rc1 for the big-endian N32 ABI, sorry. It fails 12 tests (previously I stated 'all ok' but looking at those log files again, this was incorrect) and the failing tests seem to involve pointers passed in varargs. This is a regression from 3.5.0 since it used to pass these tests, however this appears to be a small regression that's occurred as result of a major improvement to the big-endian N32 ABI (in particular, cross-linking with GCC now works in general). I therefore think we could leave this as a known issue and make sure it's fixed in 3.6.0 and 3.5.2.
> > Tom: Do you agree?
>
> Yes, this sounds OK to me.
>
> -Tom

Just for the record: http://reviews.llvm.org/D6812 fixes most of these big-endian N32 failures but we should stick to the current plan because I haven't retested the other ABI's yet.
All but one of the remaining failures is due a qemu bug. The linux user mode emulation of struct target_stat doesn't quite match any supported by glibc and causes certain stat() calls to return -1.
This is fixed in my working copy of qemu and I'll upstream it soon. The last failure is that lemon's output is wrong. I don't know the cause yet.

> > clang+llvm-3.5.1-rc2-mipsel-linux-gnu.tar.xz:
> >     All ok for default options.
> >     It will take a couple days to get results for the -mips32 test-suite (there's no FPU or local disk on this machine so some tests take a very long time).

Quick update to this one: All ok for default and -mips32.
_______________________________________________
LLVM Developers mailing list
[hidden email]         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
12